Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2337163002: Add ContextOptions field to SkCommandLineConfigGpu (Closed)

Created:
4 years, 3 months ago by csmartdalton
Modified:
4 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add ContextOptions field to SkCommandLineConfigGpu Reduces duplicate code by computing the ContextOptions in one spot. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2337163002 Committed: https://skia.googlesource.com/skia/+/6270e558c31b75d02db6f598e93f2e3b701ccb7f

Patch Set 1 #

Patch Set 2 : Add ContextOptions field to SkCommandLineConfigGpu #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -58 lines) Patch
M bench/nanobench.cpp View 2 chunks +2 lines, -15 lines 0 comments Download
M dm/DM.cpp View 2 chunks +2 lines, -16 lines 0 comments Download
M tests/GrContextFactoryTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/flags/SkCommonFlagsConfig.h View 2 chunks +5 lines, -4 lines 0 comments Download
M tools/flags/SkCommonFlagsConfig.cpp View 2 chunks +11 lines, -2 lines 0 comments Download
M tools/gpu/GrContextFactory.h View 3 chunks +10 lines, -7 lines 0 comments Download
M tools/gpu/GrContextFactory.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M tools/skiaserve/Request.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
csmartdalton
Can you recommend another reviewer for changes like this under tools/ so I don't bug ...
4 years, 3 months ago (2016-09-13 15:32:37 UTC) #3
bsalomon
lgtm, really anyone on the gpu team is fine for this kind of thing.
4 years, 3 months ago (2016-09-13 15:34:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337163002/1
4 years, 3 months ago (2016-09-13 16:08:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/11473)
4 years, 3 months ago (2016-09-13 16:13:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337163002/20001
4 years, 3 months ago (2016-09-13 17:20:19 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 17:41:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6270e558c31b75d02db6f598e93f2e3b701ccb7f

Powered by Google App Engine
This is Rietveld 408576698