Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2337143004: Add tests for DocumentModeAssassin#isOptedOutOfDocumentMode() (Closed)

Created:
4 years, 3 months ago by Theresa
Modified:
4 years, 3 months ago
Reviewers:
gone
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for DocumentModeAssassin#isOptedOutOfDocumentMode() BUG=646146 Committed: https://crrev.com/2595aa00b5c63681da6665a22f7eb75f24459cb2 Cr-Commit-Position: refs/heads/master@{#418954}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add tests for DocumentModeAssassin#isOptedOutOfDocumentMode() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassinTest.java View 1 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Theresa
ptal
4 years, 3 months ago (2016-09-15 01:08:10 UTC) #4
gone
lgtm https://codereview.chromium.org/2337143004/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassinTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassinTest.java (right): https://codereview.chromium.org/2337143004/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassinTest.java#newcode646 chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassinTest.java:646: sharedPreferencesEditor.remove(DocumentModeAssassin.OPT_OUT_STATE); Should explicitly put that this depends on ...
4 years, 3 months ago (2016-09-15 17:50:49 UTC) #7
Theresa
https://codereview.chromium.org/2337143004/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassinTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassinTest.java (right): https://codereview.chromium.org/2337143004/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassinTest.java#newcode646 chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassinTest.java:646: sharedPreferencesEditor.remove(DocumentModeAssassin.OPT_OUT_STATE); On 2016/09/15 17:50:49, dfalcantara wrote: > Should explicitly ...
4 years, 3 months ago (2016-09-15 19:53:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337143004/20001
4 years, 3 months ago (2016-09-15 19:54:17 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 20:30:54 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 20:33:22 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2595aa00b5c63681da6665a22f7eb75f24459cb2
Cr-Commit-Position: refs/heads/master@{#418954}

Powered by Google App Engine
This is Rietveld 408576698