Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 233713005: Refactoring: Changing variable type in MediaCanPlayTypeTest (Closed)

Created:
6 years, 8 months ago by amogh.bihani
Modified:
6 years, 7 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Refactoring: Changing variable type in MediaCanPlayTypeTest Changing const char* kFoo to const char kFoo[] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269772

Patch Set 1 #

Patch Set 2 : removing unused variables #

Patch Set 3 : Disabling everything for android till bug 357665 is fixed #

Patch Set 4 : undoing patchset 3 #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M content/browser/media/media_canplaytype_browsertest.cc View 1 2 3 4 5 1 chunk +21 lines, -21 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
amogh.bihani
PTAL. This is in accordance to what we discussed in the other CL https://codereview.chromium.org/230413003/
6 years, 8 months ago (2014-04-11 10:40:34 UTC) #1
xhwang
LGTM, thanks for cleaning this up!
6 years, 8 months ago (2014-04-11 17:03:14 UTC) #2
amogh.bihani
On 2014/04/11 17:03:14, xhwang wrote: > LGTM, thanks for cleaning this up! Thanks for the ...
6 years, 8 months ago (2014-04-12 02:13:29 UTC) #3
amogh.bihani
The CQ bit was checked by amogh.bihani@samsung.com
6 years, 8 months ago (2014-04-12 02:13:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/233713005/1
6 years, 8 months ago (2014-04-12 02:13:51 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-12 03:09:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 8 months ago (2014-04-12 03:09:06 UTC) #7
amogh.bihani
The CQ bit was checked by amogh.bihani@samsung.com
6 years, 8 months ago (2014-04-12 09:53:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/233713005/20001
6 years, 8 months ago (2014-04-12 09:54:08 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-12 10:52:54 UTC) #10
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=132160
6 years, 8 months ago (2014-04-12 10:52:55 UTC) #11
amogh.bihani
PTAL. The android_clang_dbg was failing because these tests are currently disabled for android (crbug 357665). ...
6 years, 8 months ago (2014-04-14 04:13:33 UTC) #12
amogh.bihani
The CQ bit was checked by amogh.bihani@samsung.com
6 years, 8 months ago (2014-04-15 04:08:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/233713005/40001
6 years, 8 months ago (2014-04-15 04:09:14 UTC) #14
amogh.bihani
The CQ bit was unchecked by amogh.bihani@samsung.com
6 years, 8 months ago (2014-04-15 06:08:05 UTC) #15
amogh.bihani
I think we won't be able to merge this before the tests are re-enabled for ...
6 years, 8 months ago (2014-04-16 08:36:41 UTC) #16
amogh.bihani
The CQ bit was checked by amogh.bihani@samsung.com
6 years, 7 months ago (2014-05-12 09:37:06 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/233713005/100001
6 years, 7 months ago (2014-05-12 09:37:19 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-12 11:12:51 UTC) #19
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 12:42:45 UTC) #20
Message was sent while issue was closed.
Change committed as 269772

Powered by Google App Engine
This is Rietveld 408576698