[NTP Snippets] Metrics: switch over known categories

components/ntp_snippets/content_suggestions_metrics.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/content_suggestions_metrics.h"
 
 #include <string>
 
 #include "base/metrics/histogram.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 26 matching lines @@
 const char kHistogramVisitDuration[] =
     "NewTabPage.ContentSuggestions.VisitDuration";
 const char kHistogramMoreButtonShown[] =
     "NewTabPage.ContentSuggestions.MoreButtonShown";
 const char kHistogramMoreButtonClicked[] =
     "NewTabPage.ContentSuggestions.MoreButtonClicked";
 
 const char kPerCategoryHistogramFormat[] = "%s.%s";
 
 std::string GetCategorySuffix(Category category) {
-  // TODO(treib): Find a way to produce a compile error if a known category
-  // isn't listed here.
-  if (category.IsKnownCategory(KnownCategories::RECENT_TABS))
-    return "RecentTabs";
-  if (category.IsKnownCategory(KnownCategories::DOWNLOADS))
-    return "Downloads";
-  if (category.IsKnownCategory(KnownCategories::BOOKMARKS))
-    return "Bookmarks";
-  if (category.IsKnownCategory(KnownCategories::ARTICLES))
-    return "Articles";
-  // All other categories go into a single "Experimental" bucket.
+  if (category.IsAnyKnownCategory()) {
+    KnownCategories known_category =
+        static_cast<KnownCategories>(category.id());
+    switch (known_category) {

[jkrcal, 2016/09/13 16:08:05]

Way better, thanks!

+      case KnownCategories::RECENT_TABS:
+        return "RecentTabs";
+      case KnownCategories::DOWNLOADS:
+        return "Downloads";
+      case KnownCategories::BOOKMARKS:
+        return "Bookmarks";
+      case KnownCategories::PHYSICAL_WEB_PAGES:
+        return "PhysicalWeb";
+      case KnownCategories::ARTICLES:
+        return "Articles";
+      case KnownCategories::LOCAL_CATEGORIES_COUNT:
+      case KnownCategories::REMOTE_CATEGORIES_OFFSET:
+        NOTREACHED();
+        break;
+    }
+  }
+  // All other (unknown) categories go into a single "Experimental" bucket.
   return "Experimental";
 }
 
 std::string GetCategoryHistogramName(const char* base_name, Category category) {
   return base::StringPrintf(kPerCategoryHistogramFormat, base_name,
                             GetCategorySuffix(category).c_str());
 }
 
 // This corresponds to UMA_HISTOGRAM_ENUMERATION, for use with dynamic histogram
 // names.
@@ skipping 151 matching lines @@
 
 void OnMoreButtonClicked(Category category, int position) {
   // The "more" card can appear in addition to the actual suggestions, so add
   // one extra bucket to this histogram.
   LogCategoryHistogramEnumeration(kHistogramMoreButtonClicked, category,
                                   position, kMaxSuggestionsPerCategory + 1);
 }
 
 }  // namespace metrics
 }  // namespace ntp_snippets