Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2337063003: [Extensions] Add metrics for asynchronous port creation (Closed)

Created:
4 years, 3 months ago by Devlin
Modified:
4 years, 3 months ago
Reviewers:
lazyboy, Mark P
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Add metrics for asynchronous port creation BUG=642380 Committed: https://crrev.com/4899757a47ed210d8290c81f2a02c0feeacea809 Cr-Commit-Position: refs/heads/master@{#418709}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -5 lines) Patch
M extensions/renderer/extension_frame_helper.h View 2 chunks +3 lines, -1 line 0 comments Download
M extensions/renderer/extension_frame_helper.cc View 6 chunks +45 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Devlin
4 years, 3 months ago (2016-09-13 17:51:10 UTC) #2
lazyboy
lgtm.
4 years, 3 months ago (2016-09-13 20:01:29 UTC) #3
Devlin
Mark, mind taking a look at the histograms?
4 years, 3 months ago (2016-09-13 23:03:09 UTC) #5
Mark P
histograms.xml lgtm
4 years, 3 months ago (2016-09-14 19:41:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337063003/20001
4 years, 3 months ago (2016-09-14 22:54:21 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 23:00:19 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 23:03:49 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4899757a47ed210d8290c81f2a02c0feeacea809
Cr-Commit-Position: refs/heads/master@{#418709}

Powered by Google App Engine
This is Rietveld 408576698