Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Issue 2337033002: [interpreter] Add regression test for bogus OSR entry. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Add regression test for bogus OSR entry. This adds a regression test for a bug where {OsrPoll} instructions within the bytecode stream ended up outside of actual loops. This has been fixed already, by merging {OsrPoll} into the backwards branch. R=rmcilroy@chromium.org TEST=mjsunit/regress/regress-crbug-645888 BUG=chromium:645888 Committed: https://crrev.com/85289749f476379964e39f6f4cdc2a8f6ea5b9ec Cr-Commit-Position: refs/heads/master@{#39385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
A test/mjsunit/regress/regress-crbug-645888.js View 1 chunk +18 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
Michael Starzinger
4 years, 3 months ago (2016-09-13 09:43:54 UTC) #7
rmcilroy
lgtm
4 years, 3 months ago (2016-09-13 10:54:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337033002/1
4 years, 3 months ago (2016-09-13 13:20:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 13:22:58 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 13:23:32 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85289749f476379964e39f6f4cdc2a8f6ea5b9ec
Cr-Commit-Position: refs/heads/master@{#39385}

Powered by Google App Engine
This is Rietveld 408576698