Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 233703003: Rename GrAtlasedLayer to GrCachedLayer (since not all cached layers are atlased) (Closed)

Created:
6 years, 8 months ago by robertphillips
Modified:
6 years, 8 months ago
Reviewers:
jvanverth1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Rename GrAtlasedLayer to GrCachedLayer (since not all cached layers are atlased) This is mainly a renaming CL but it does add a ref-counted ptr to the backing GrTexture for non-atlased layers (the only kind working right now) Committed: http://code.google.com/p/skia/source/detail?r=14152

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -19 lines) Patch
M src/gpu/GrLayerCache.h View 2 chunks +39 lines, -12 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
6 years, 8 months ago (2014-04-10 19:55:37 UTC) #1
jvanverth1
LGTM. I'm just a little confused though -- is the texture currently set or is ...
6 years, 8 months ago (2014-04-10 20:40:08 UTC) #2
robertphillips
That change is in my check-that-pre-rendering-saveLayers-is-worth-it hack (https://codereview.chromium.org/227603006/). I think I may be able to ...
6 years, 8 months ago (2014-04-11 11:11:04 UTC) #3
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 8 months ago (2014-04-11 11:11:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/233703003/1
6 years, 8 months ago (2014-04-11 11:11:33 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 15:53:52 UTC) #6
Message was sent while issue was closed.
Change committed as 14152

Powered by Google App Engine
This is Rietveld 408576698