Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: src/IceTargetLoweringMIPS32.cpp

Issue 2337023003: Subzero, MIPS32: lowerSelect for i1, i8, i16, i32, f32, f64 (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Addressing review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTargetLoweringMIPS32.cpp
diff --git a/src/IceTargetLoweringMIPS32.cpp b/src/IceTargetLoweringMIPS32.cpp
index 237eef46ca435632c96c83e6d002eca2c0f4141a..e4d52219d9b88306fd4d05e983f71bcfdd5b02d2 100644
--- a/src/IceTargetLoweringMIPS32.cpp
+++ b/src/IceTargetLoweringMIPS32.cpp
@@ -3135,11 +3135,22 @@ void TargetMIPS32::lowerRet(const InstRet *Instr) {
if (Instr->hasRetValue()) {
Operand *Src0 = Instr->getRetValue();
switch (Src0->getType()) {
+ case IceType_f32: {
+ Operand *Src0F = legalize(Src0, Legal_Reg);
Jim Stichnoth 2016/09/14 06:02:17 legalizeToReg(Src0) ? here and below
obucinac 2016/09/14 12:39:02 Done.
+ Reg = makeReg(Src0F->getType(), RegMIPS32::Reg_F0);
+ _mov(Reg, Src0F);
+ break;
+ }
+ case IceType_f64: {
+ Operand *Src0F = legalize(Src0, Legal_Reg);
+ Reg = makeReg(Src0F->getType(), RegMIPS32::Reg_F0F1);
+ _mov(Reg, Src0F);
+ break;
+ }
case IceType_i1:
case IceType_i8:
case IceType_i16:
case IceType_i32: {
- // Reg = legalizeToReg(Src0, RegMIPS32::Reg_V0);
Operand *Src0F = legalize(Src0, Legal_Reg);
Reg = makeReg(Src0F->getType(), RegMIPS32::Reg_V0);
_mov(Reg, Src0F);
@@ -3161,7 +3172,44 @@ void TargetMIPS32::lowerRet(const InstRet *Instr) {
}
void TargetMIPS32::lowerSelect(const InstSelect *Instr) {
- UnimplementedLoweringError(this, Instr);
+ Variable *Dest = Instr->getDest();
+ const Type DestTy = Dest->getType();
+
+ if (DestTy == IceType_i64 || isVectorType(DestTy)) {
+ UnimplementedLoweringError(this, Instr);
+ return;
+ }
+
+ Variable *DestR = legalizeToReg(Dest);
+ Variable *SrcTR = legalizeToReg(Instr->getTrueOperand());
+ Variable *SrcFR = legalizeToReg(Instr->getFalseOperand());
+
+ Variable *ConditionR = legalizeToReg(Instr->getCondition());
+
+ assert(Instr->getCondition()->getType() == IceType_i1);
+
+ switch (DestTy) {
+ case IceType_i1:
+ case IceType_i8:
+ case IceType_i16:
+ case IceType_i32:
+ _movn(SrcFR, SrcTR, ConditionR);
+ _mov(DestR, SrcFR);
+ _mov(Dest, DestR);
+ break;
+ case IceType_f32:
+ _movn_s(SrcFR, SrcTR, ConditionR);
+ _mov(DestR, SrcFR);
+ _mov(Dest, DestR);
+ break;
+ case IceType_f64:
+ _movn_d(SrcFR, SrcTR, ConditionR);
+ _mov(DestR, SrcFR);
+ _mov(Dest, DestR);
+ break;
+ default:
+ UnimplementedLoweringError(this, Instr);
+ }
}
void TargetMIPS32::lowerShuffleVector(const InstShuffleVector *Instr) {

Powered by Google App Engine
This is Rietveld 408576698