Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: tests_lit/llvm2ice_tests/select-opt.ll

Issue 2337023003: Subzero, MIPS32: lowerSelect for i1, i8, i16, i32, f32, f64 (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Addressing review comments, fix invalid condition in Mov::emitSingleDestSingleSource Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/IceInstMIPS32.cpp ('K') | « tests_lit/llvm2ice_tests/fp.cmp.ll ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 ; Simple test of the select instruction. The CHECK lines are only 1 ; Simple test of the select instruction. The CHECK lines are only
2 ; checking for basic instruction patterns that should be present 2 ; checking for basic instruction patterns that should be present
3 ; regardless of the optimization level, so there are no special OPTM1 3 ; regardless of the optimization level, so there are no special OPTM1
4 ; match lines. 4 ; match lines.
5 5
6 ; RUN: %if --need=target_X8632 --command %p2i --filetype=obj --disassemble \ 6 ; RUN: %if --need=target_X8632 --command %p2i --filetype=obj --disassemble \
7 ; RUN: --target x8632 -i %s --args -O2 -allow-externally-defined-symbols \ 7 ; RUN: --target x8632 -i %s --args -O2 -allow-externally-defined-symbols \
8 ; RUN: | %if --need=target_X8632 --command FileCheck %s 8 ; RUN: | %if --need=target_X8632 --command FileCheck %s
9 ; RUN: %if --need=target_X8632 --command %p2i --filetype=obj --disassemble \ 9 ; RUN: %if --need=target_X8632 --command %p2i --filetype=obj --disassemble \
10 ; RUN: --target x8632 -i %s --args -Om1 -allow-externally-defined-symbols \ 10 ; RUN: --target x8632 -i %s --args -Om1 -allow-externally-defined-symbols \
11 ; RUN: | %if --need=target_X8632 --command FileCheck %s 11 ; RUN: | %if --need=target_X8632 --command FileCheck %s
12 12
13 ; RUN: %if --need=target_ARM32 --need=allow_dump \ 13 ; RUN: %if --need=target_ARM32 --need=allow_dump \
14 ; RUN: --command %p2i --filetype=asm --assemble \ 14 ; RUN: --command %p2i --filetype=asm --assemble \
15 ; RUN: --disassemble --target arm32 -i %s --args -O2 \ 15 ; RUN: --disassemble --target arm32 -i %s --args -O2 \
16 ; RUN: -allow-externally-defined-symbols \ 16 ; RUN: -allow-externally-defined-symbols \
17 ; RUN: | %if --need=target_ARM32 --need=allow_dump \ 17 ; RUN: | %if --need=target_ARM32 --need=allow_dump \
18 ; RUN: --command FileCheck --check-prefix ARM32 --check-prefix ARM32-O2 %s 18 ; RUN: --command FileCheck --check-prefix ARM32 --check-prefix ARM32-O2 %s
19 ; RUN: %if --need=target_ARM32 --need=allow_dump \ 19 ; RUN: %if --need=target_ARM32 --need=allow_dump \
20 ; RUN: --command %p2i --filetype=asm --assemble \ 20 ; RUN: --command %p2i --filetype=asm --assemble \
21 ; RUN: --disassemble --target arm32 -i %s --args -Om1 \ 21 ; RUN: --disassemble --target arm32 -i %s --args -Om1 \
22 ; RUN: -allow-externally-defined-symbols \ 22 ; RUN: -allow-externally-defined-symbols \
23 ; RUN: | %if --need=target_ARM32 --need=allow_dump \ 23 ; RUN: | %if --need=target_ARM32 --need=allow_dump \
24 ; RUN: --command FileCheck --check-prefix ARM32 --check-prefix ARM32-OM1 %s 24 ; RUN: --command FileCheck --check-prefix ARM32 --check-prefix ARM32-OM1 %s
25 25
26 ; RUN: %if --need=target_MIPS32 --need=allow_dump \
27 ; RUN: --command %p2i --filetype=asm --assemble \
28 ; RUN: --disassemble --target mips32 -i %s --args -Om1 \
29 ; RUN: -allow-externally-defined-symbols -skip-unimplemented \
30 ; RUN: | %if --need=target_MIPS32 --need=allow_dump \
31 ; RUN: --command FileCheck --check-prefix MIPS32 %s
32
33 ; RUN: %if --need=target_MIPS32 --need=allow_dump \
34 ; RUN: --command %p2i --filetype=asm --assemble \
35 ; RUN: --disassemble --target mips32 -i %s --args -O2 \
36 ; RUN: -allow-externally-defined-symbols -skip-unimplemented \
37 ; RUN: | %if --need=target_MIPS32 --need=allow_dump \
38 ; RUN: --command FileCheck --check-prefix MIPS32 %s
39
26 define internal void @testSelect(i32 %a, i32 %b) { 40 define internal void @testSelect(i32 %a, i32 %b) {
27 entry: 41 entry:
28 %cmp = icmp slt i32 %a, %b 42 %cmp = icmp slt i32 %a, %b
29 %cond = select i1 %cmp, i32 %a, i32 %b 43 %cond = select i1 %cmp, i32 %a, i32 %b
30 tail call void @useInt(i32 %cond) 44 tail call void @useInt(i32 %cond)
31 %cmp1 = icmp sgt i32 %a, %b 45 %cmp1 = icmp sgt i32 %a, %b
32 %cond2 = select i1 %cmp1, i32 10, i32 20 46 %cond2 = select i1 %cmp1, i32 10, i32 20
33 tail call void @useInt(i32 %cond2) 47 tail call void @useInt(i32 %cond2)
34 ; Create "fake" uses of %cmp and %cmp1 to prevent O2 bool folding. 48 ; Create "fake" uses of %cmp and %cmp1 to prevent O2 bool folding.
35 %d1 = zext i1 %cmp to i32 49 %d1 = zext i1 %cmp to i32
(...skipping 18 matching lines...) Expand all
54 ; ARM32: bl {{.*}} useInt 68 ; ARM32: bl {{.*}} useInt
55 ; ARM32-Om1: mov {{.*}}, #20 69 ; ARM32-Om1: mov {{.*}}, #20
56 ; ARM32-O2: mov [[REG:r[0-9]+]], #20 70 ; ARM32-O2: mov [[REG:r[0-9]+]], #20
57 ; ARM32: tst 71 ; ARM32: tst
58 ; ARM32-Om1: movne {{.*}}, #10 72 ; ARM32-Om1: movne {{.*}}, #10
59 ; ARM32-O2: movne [[REG]], #10 73 ; ARM32-O2: movne [[REG]], #10
60 ; ARM32: bl {{.*}} useInt 74 ; ARM32: bl {{.*}} useInt
61 ; ARM32: bl {{.*}} useInt 75 ; ARM32: bl {{.*}} useInt
62 ; ARM32: bl {{.*}} useInt 76 ; ARM32: bl {{.*}} useInt
63 ; ARM32: bx lr 77 ; ARM32: bx lr
78 ; MIPS32-LABEL: testSelect
79 ; MIPS32: slt {{.*}}
80 ; MIPS32: movn {{.*}}
81 ; MIPS32: move {{.*}}
64 82
65 ; Check for valid addressing mode in the cmp instruction when the 83 ; Check for valid addressing mode in the cmp instruction when the
66 ; operand is an immediate. 84 ; operand is an immediate.
67 define internal i32 @testSelectImm32(i32 %a, i32 %b) { 85 define internal i32 @testSelectImm32(i32 %a, i32 %b) {
68 entry: 86 entry:
69 %cond = select i1 false, i32 %a, i32 %b 87 %cond = select i1 false, i32 %a, i32 %b
70 ret i32 %cond 88 ret i32 %cond
71 } 89 }
72 ; CHECK-LABEL: testSelectImm32 90 ; CHECK-LABEL: testSelectImm32
73 ; CHECK-NOT: cmp 0x{{[0-9a-f]+}}, 91 ; CHECK-NOT: cmp 0x{{[0-9a-f]+}},
74 ; ARM32-LABEL: testSelectImm32 92 ; ARM32-LABEL: testSelectImm32
75 ; ARM32-NOT: cmp #{{.*}}, 93 ; ARM32-NOT: cmp #{{.*}},
94 ; MIPS32-LABEL: testSelectImm32
95 ; MIPS32: movn {{.*}}
96 ; MIPS32: move {{.*}}
76 97
77 ; Check for valid addressing mode in the cmp instruction when the 98 ; Check for valid addressing mode in the cmp instruction when the
78 ; operand is an immediate. There is a different x86-32 lowering 99 ; operand is an immediate. There is a different x86-32 lowering
79 ; sequence for 64-bit operands. 100 ; sequence for 64-bit operands.
80 define internal i64 @testSelectImm64(i64 %a, i64 %b) { 101 define internal i64 @testSelectImm64(i64 %a, i64 %b) {
81 entry: 102 entry:
82 %cond = select i1 true, i64 %a, i64 %b 103 %cond = select i1 true, i64 %a, i64 %b
83 ret i64 %cond 104 ret i64 %cond
84 } 105 }
85 ; CHECK-LABEL: testSelectImm64 106 ; CHECK-LABEL: testSelectImm64
86 ; CHECK-NOT: cmp 0x{{[0-9a-f]+}}, 107 ; CHECK-NOT: cmp 0x{{[0-9a-f]+}},
87 ; ARM32-LABEL: testSelectImm64 108 ; ARM32-LABEL: testSelectImm64
88 ; ARM32-NOT: cmp #{{.*}}, 109 ; ARM32-NOT: cmp #{{.*}},
110 ; MIPS32-LABEL: testSelectImm64
OLDNEW
« src/IceInstMIPS32.cpp ('K') | « tests_lit/llvm2ice_tests/fp.cmp.ll ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698