tools/determinism/compare_build_artifacts.py - Issue 2337013002: .o could be COFF object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/determinism/compare_build_artifacts.py

Issue 2337013002: .o could be COFF object. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/determinism/compare_build_artifacts.py

diff --git a/tools/determinism/compare_build_artifacts.py b/tools/determinism/compare_build_artifacts.py

index 982ed3b13d7265ce507cd4c956a1435b3e1c2932..92256a7aaa887534d7b5d6652969ecc127ed26a7 100755

--- a/tools/determinism/compare_build_artifacts.py

+++ b/tools/determinism/compare_build_artifacts.py

@@ -452,7 +452,8 @@ def diff_binary(first_filepath, second_filepath, file_len):

# 4 - 7: timestamp.

# ....

COFF_HEADER_TO_COMPARE_SIZE = 8

- if (sys.platform == 'win32' and first_filepath.endswith('.obj')

+ if (sys.platform == 'win32'

+ and os.path.splitext(first_filepath)[1] in ('.obj', '.o')

M-A Ruel 2016/09/13 14:20:22 I would prefer '.o', '.obj' so they are in order.

Yoshisato Yanagisawa 2016/09/14 01:04:36 Done.

and file_len > COFF_HEADER_TO_COMPARE_SIZE):

rhs_data = rhs.read(COFF_HEADER_TO_COMPARE_SIZE)

lhs_data = lhs.read(COFF_HEADER_TO_COMPARE_SIZE)

« no previous file with comments | « no previous file | no next file » | no next file with comments »