.o could be COFF object.

.o could be COFF object.

clang-cl make .o as an object file, which is also COFF format file.

BUG=439737
Committed: https://crrev.com/69b56e9937861ad7b3884756445dc202fa58bfb4
Cr-Commit-Position: refs/heads/master@{#418459}

[Yoshisato Yanagisawa, 2016-09-13 07:17:26]

yyanagisawa@chromium.org changed reviewers:
+ dpranke@google.com, maruel@chromium.org

[Yoshisato Yanagisawa, 2016-09-13 09:08:04]

Description was changed from

==========
.o could be COFF object.

clang-cl make .o as an object file, which is also COFF format file.

BUG=439737
==========

to

==========
.o could be COFF object.

clang-cl make .o as an object file, which is also COFF format file.

BUG=439737
==========

[Yoshisato Yanagisawa, 2016-09-13 09:08:04]

yyanagisawa@chromium.org changed reviewers:
+ dpranke@chromium.org
- dpranke@google.com

[M-A Ruel, 2016-09-13 14:20:22]

lgtm

https://codereview.chromium.org/2337013002/diff/1/tools/determinism/compare_b...
File tools/determinism/compare_build_artifacts.py (right):

https://codereview.chromium.org/2337013002/diff/1/tools/determinism/compare_b...
tools/determinism/compare_build_artifacts.py:456: and
os.path.splitext(first_filepath)[1] in ('.obj', '.o')
I would prefer '.o', '.obj' so they are in order.

[Yoshisato Yanagisawa, 2016-09-14 01:04:36]

https://codereview.chromium.org/2337013002/diff/1/tools/determinism/compare_b...
File tools/determinism/compare_build_artifacts.py (right):

https://codereview.chromium.org/2337013002/diff/1/tools/determinism/compare_b...
tools/determinism/compare_build_artifacts.py:456: and
os.path.splitext(first_filepath)[1] in ('.obj', '.o')
On 2016/09/13 14:20:22, M-A Ruel wrote:
> I would prefer '.o', '.obj' so they are in order.

Done.

[Yoshisato Yanagisawa, 2016-09-14 01:05:29]

The CQ bit was checked by yyanagisawa@chromium.org

[Yoshisato Yanagisawa, 2016-09-14 01:05:29]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/2337013002/#ps20001
(title: "rebase + changed .o and .obj order")

[commit-bot: I haz the power, 2016-09-14 01:06:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 02:38:28]

Description was changed from

==========
.o could be COFF object.

clang-cl make .o as an object file, which is also COFF format file.

BUG=439737
==========

to

==========
.o could be COFF object.

clang-cl make .o as an object file, which is also COFF format file.

BUG=439737
==========

[commit-bot: I haz the power, 2016-09-14 02:38:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-14 02:41:23]

Description was changed from

==========
.o could be COFF object.

clang-cl make .o as an object file, which is also COFF format file.

BUG=439737
==========

to

==========
.o could be COFF object.

clang-cl make .o as an object file, which is also COFF format file.

BUG=439737

Committed: https://crrev.com/69b56e9937861ad7b3884756445dc202fa58bfb4
Cr-Commit-Position: refs/heads/master@{#418459}
==========

[commit-bot: I haz the power, 2016-09-14 02:41:24]

Patchset 2 (id:??) landed as
https://crrev.com/69b56e9937861ad7b3884756445dc202fa58bfb4
Cr-Commit-Position: refs/heads/master@{#418459}