third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp - Issue 2337003002: Worker: Notify WorkerThread lifecycle events via WorkerReportingProxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

Issue 2337003002: Worker: Notify WorkerThread lifecycle events via WorkerReportingProxy (Closed)

Patch Set: fix tests Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkerGlobalScope.h ('k') | third_party/WebKit/Source/core/workers/WorkerReportingProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

diff --git a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

index bcf5f54ea660cf42026a3fea66e81703fcc25428..2345354033856190fcf5fdabc6dd94a4d11113fe 100644

--- a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

+++ b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

@@ -213,7 +213,7 @@ void WorkerGlobalScope::importScripts(const Vector<String>& urls, ExceptionState

}

InspectorInstrumentation::scriptImported(&executionContext, scriptLoader->identifier(), scriptLoader->script());

- scriptLoaded(scriptLoader->script().length(), scriptLoader->cachedMetadata() ? scriptLoader->cachedMetadata()->size() : 0);

+ thread()->workerReportingProxy().didLoadWorkerScript(scriptLoader->script().length(), scriptLoader->cachedMetadata() ? scriptLoader->cachedMetadata()->size() : 0);

ErrorEvent* errorEvent = nullptr;

std::unique_ptr<Vector<char>> cachedMetaData(scriptLoader->releaseCachedMetadata());