Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: components/offline_pages/offline_page_model_impl_unittest.cc

Issue 2336973005: [Offline Pages] Removes the unused "HasPages" function. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_impl_unittest.cc
diff --git a/components/offline_pages/offline_page_model_impl_unittest.cc b/components/offline_pages/offline_page_model_impl_unittest.cc
index 25e64335c0e96a6b70ce2c860f6b9895653ee26e..73273c7c1c82110fd8cdc0786cbdb224adbefb08 100644
--- a/components/offline_pages/offline_page_model_impl_unittest.cc
+++ b/components/offline_pages/offline_page_model_impl_unittest.cc
@@ -83,7 +83,6 @@ class OfflinePageModelImplTest
// OfflinePageModel callbacks.
void OnSavePageDone(SavePageResult result, int64_t offline_id);
void OnDeletePageDone(DeletePageResult result);
- void OnHasPagesDone(bool result);
void OnCheckPagesExistOfflineDone(const CheckPagesExistOfflineResult& result);
void OnClearAllDone();
void OnGetOfflineIdsForClientIdDone(MultipleOfflineIdResult* storage,
@@ -181,7 +180,6 @@ class OfflinePageModelImplTest
base::FilePath last_archiver_path_;
int64_t last_deleted_offline_id_;
ClientId last_deleted_client_id_;
- bool last_has_pages_result_;
CheckPagesExistOfflineResult last_pages_exist_result_;
int last_cleared_pages_count_;
DeletePageResult last_clear_page_result_;
@@ -243,10 +241,6 @@ void OfflinePageModelImplTest::OnDeletePageDone(DeletePageResult result) {
last_delete_result_ = result;
}
-void OfflinePageModelImplTest::OnHasPagesDone(bool result) {
- last_has_pages_result_ = result;
-}
-
void OfflinePageModelImplTest::OnCheckPagesExistOfflineDone(
const CheckPagesExistOfflineResult& result) {
last_pages_exist_result_ = result;
@@ -415,11 +409,13 @@ MultipleOfflinePageItemResult OfflinePageModelImplTest::GetPagesByOnlineURL(
}
bool OfflinePageModelImplTest::HasPages(std::string name_space) {
- model()->HasPages(
- name_space,
- base::Bind(&OfflinePageModelImplTest::OnHasPagesDone, AsWeakPtr()));
- PumpLoop();
- return last_has_pages_result_;
+ MultipleOfflinePageItemResult all_pages = GetAllPages();
+ for (const auto& page : all_pages) {
+ if (page.client_id.name_space == name_space)
+ return true;
+ }
+
+ return false;
}
TEST_F(OfflinePageModelImplTest, SavePageSuccessful) {
« no previous file with comments | « components/offline_pages/offline_page_model_impl.cc ('k') | components/offline_pages/stub_offline_page_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698