Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2336973004: ValueDeserializer: Pretenure objects while deserializing large objects. (Closed)

Created:
4 years, 3 months ago by jbroman
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ValueDeserializer: Pretenure objects while deserializing large objects. json-parser does the same thing. This drastically reduces GC cost when deserializing objects large enough that multiple collections are likely (since it saves the effort to move them to the old generation, when we know that the objects we create will persist at least until the deserializer finishes). The threshold was chosen to match json-parser. This patch reduces deserialization time on a large blob of JSON-y data by approximately 30%. BUG=chromium:148757 Committed: https://crrev.com/66dbc77eaf6b7fdb15b395401d556d3af51758e4 Cr-Commit-Position: refs/heads/master@{#39396}

Patch Set 1 #

Patch Set 2 : remove the anonymous namespace; it is superfluous here #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -22 lines) Patch
M src/value-serializer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/value-serializer.cc View 1 13 chunks +32 lines, -22 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
jbroman
4 years, 3 months ago (2016-09-13 23:36:54 UTC) #7
Jakob Kummerow
lgtm
4 years, 3 months ago (2016-09-14 01:29:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336973004/20001
4 years, 3 months ago (2016-09-14 02:12:57 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 02:35:05 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 02:35:58 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66dbc77eaf6b7fdb15b395401d556d3af51758e4
Cr-Commit-Position: refs/heads/master@{#39396}

Powered by Google App Engine
This is Rietveld 408576698