Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2336973003: Add tests for gamma correction of gradient stops to gamma GM (Closed)

Created:
4 years, 3 months ago by Brian Osman
Modified:
4 years, 3 months ago
Reviewers:
f(malita), mtklein, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add tests for gamma correction of gradient stops to gamma GM Includes three different cases to exercise different cases in Ganesh. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336973003 Committed: https://skia.googlesource.com/skia/+/490452ec4743813b9508e6fe78755ae9e006dbe2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -11 lines) Patch
M gm/gamma.cpp View 2 chunks +52 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Brian Osman
Raster backend appears to do the right thing here. GPU doesn't (yet).
4 years, 3 months ago (2016-09-13 14:24:56 UTC) #5
f(malita)
lgtm
4 years, 3 months ago (2016-09-13 15:20:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336973003/1
4 years, 3 months ago (2016-09-13 15:23:46 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 15:24:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/490452ec4743813b9508e6fe78755ae9e006dbe2

Powered by Google App Engine
This is Rietveld 408576698