cc: Include viewport clip in visible rect of clip children

cc: Include viewport clip in visible rect of clip children

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/b4df40340a70a533e1aaf5464fee53bfc2621fa2
Cr-Commit-Position: refs/heads/master@{#418312}

[jaydasika, 2016-09-13 01:07:13]

Description was changed from

==========
cc: Include viewport clip in visible rect of clip children

BUG=642054
==========

to

==========
cc: Include viewport clip in visible rect of clip children

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-09-13 01:11:56]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 01:12:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaydasika, 2016-09-13 01:12:28]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org

[jaydasika, 2016-09-13 01:12:28]

PTAL

[commit-bot: I haz the power, 2016-09-13 02:27:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 02:27:48]

Dry run: This issue passed the CQ dry run.

[weiliangc, 2016-09-13 15:44:13]

weiliangc@chromium.org changed reviewers:
+ weiliangc@chromium.org

[weiliangc, 2016-09-13 15:44:14]

https://codereview.chromium.org/2336923002/diff/20001/cc/trees/draw_property_...
File cc/trees/draw_property_utils.cc (right):

https://codereview.chromium.org/2336923002/diff/20001/cc/trees/draw_property_...
cc/trees/draw_property_utils.cc:93: bool use_combined_clip) {
clip_rect_in_target_space is output of this function. We should put output as
the last parameter, and use_combined_clip goes before that.

https://codereview.chromium.org/2336923002/diff/20001/cc/trees/draw_property_...
cc/trees/draw_property_utils.cc:345: bool use_combined_clip = false;
nit: I think this name might not be easy to understand for people who are not
familiar with the code. How about renaming it to for_visible_rect_calculation or
something like that, since it is used for saying whether we are using the helper
function to calculate visible rect or clip rect. And inside the
ComputeClipRectInTargetSpace function, we can say for visible rect calculation
we use combined_clip?

[jaydasika, 2016-09-13 17:17:56]

https://codereview.chromium.org/2336923002/diff/20001/cc/trees/draw_property_...
File cc/trees/draw_property_utils.cc (right):

https://codereview.chromium.org/2336923002/diff/20001/cc/trees/draw_property_...
cc/trees/draw_property_utils.cc:93: bool use_combined_clip) {
On 2016/09/13 15:44:14, weiliangc wrote:
> clip_rect_in_target_space is output of this function. We should put output as
> the last parameter, and use_combined_clip goes before that.

Done.

https://codereview.chromium.org/2336923002/diff/20001/cc/trees/draw_property_...
cc/trees/draw_property_utils.cc:345: bool use_combined_clip = false;
On 2016/09/13 15:44:14, weiliangc wrote:
> nit: I think this name might not be easy to understand for people who are not
> familiar with the code. How about renaming it to for_visible_rect_calculation
or
> something like that, since it is used for saying whether we are using the
helper
> function to calculate visible rect or clip rect. And inside the
> ComputeClipRectInTargetSpace function, we can say for visible rect calculation
> we use combined_clip?

Done.

[jaydasika, 2016-09-13 17:18:03]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 17:18:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[weiliangc, 2016-09-13 17:21:42]

Thanks! LGTM

[commit-bot: I haz the power, 2016-09-13 18:29:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 18:29:27]

Dry run: This issue passed the CQ dry run.

[jaydasika, 2016-09-13 18:30:03]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-09-13 18:31:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 18:39:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-13 18:41:01]

Description was changed from

==========
cc: Include viewport clip in visible rect of clip children

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Include viewport clip in visible rect of clip children

BUG=642054
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/b4df40340a70a533e1aaf5464fee53bfc2621fa2
Cr-Commit-Position: refs/heads/master@{#418312}
==========

[commit-bot: I haz the power, 2016-09-13 18:41:02]

Patchset 3 (id:??) landed as
https://crrev.com/b4df40340a70a533e1aaf5464fee53bfc2621fa2
Cr-Commit-Position: refs/heads/master@{#418312}