Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Issue 2336913006: Introduce ExpectApproxEq, a helper function that allows making assertions that certain values are e… (Closed)

Created:
4 years, 3 months ago by Victor Vasiliev
Modified:
4 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce ExpectApproxEq, a helper function that allows making assertions that certain values are equal within the margin of specified relative error. This is to avoid manually hacking around test failures like: Expected equality of these values: expected_pacing_rate Which is: 10.78 Mbits/s (1.35 Mbytes/s) sender_->PacingRate(0) Which is: 10.78 Mbits/s (1.35 Mbytes/s) Merge internal change: 132613274 R=rch@chromium.org BUG= Committed: https://crrev.com/aaa4fe750e44ccb3d46e585abcaa17a976f2bead Cr-Commit-Position: refs/heads/master@{#418696}

Patch Set 1 #

Patch Set 2 : Fix MSVC warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -3 lines) Patch
M net/net.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/congestion_control/simulation/simulator_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +16 lines, -0 lines 0 comments Download
A net/quic/test_tools/quic_test_utils_test.cc View 1 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Victor Vasiliev
4 years, 3 months ago (2016-09-14 19:41:16 UTC) #1
Ryan Hamilton
lgtm
4 years, 3 months ago (2016-09-14 19:52:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336913006/20001
4 years, 3 months ago (2016-09-14 21:44:31 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 22:26:44 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 22:28:28 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aaa4fe750e44ccb3d46e585abcaa17a976f2bead
Cr-Commit-Position: refs/heads/master@{#418696}

Powered by Google App Engine
This is Rietveld 408576698