Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2336913003: Mechanical change of base::Time to base::TimeTicks in the component updater. (Closed)

Created:
4 years, 3 months ago by Sorin Jianu
Modified:
4 years, 3 months ago
Reviewers:
waffles
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mechanical change of base::Time to base::TimeTicks in the component updater. The call sites where the time is used to compute time deltas within the lifetime of the Chrome browser process are affected. BUG=646619 Committed: https://crrev.com/1827db1578e1f15441b9a8ec631408b7ff061894 Cr-Commit-Position: refs/heads/master@{#418959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M components/component_updater/component_updater_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/update_client/action_update_check.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/update_client/background_downloader_win.h View 2 chunks +4 lines, -2 lines 0 comments Download
M components/update_client/background_downloader_win.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/update_client/crx_update_item.h View 1 chunk +1 line, -1 line 0 comments Download
M components/update_client/update_engine.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/update_client/update_engine.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/update_client/url_fetcher_downloader.h View 1 chunk +1 line, -1 line 0 comments Download
M components/update_client/url_fetcher_downloader.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Sorin Jianu
4 years, 3 months ago (2016-09-13 23:01:11 UTC) #4
waffles
lgtm
4 years, 3 months ago (2016-09-15 18:09:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336913003/1
4 years, 3 months ago (2016-09-15 19:59:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 20:43:53 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 20:47:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1827db1578e1f15441b9a8ec631408b7ff061894
Cr-Commit-Position: refs/heads/master@{#418959}

Powered by Google App Engine
This is Rietveld 408576698