Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 2336913002: Remove LibraryElement.visibleLibraries. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove LibraryElement.visibleLibraries. It is not used now. The only other is smoke, and its only in test, and it is actually used incorrectly there. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8c1d5a3b56215a334b79c6af98efaf87d142e75c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -126 lines) Patch
M pkg/analyzer/lib/dart/element/element.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 2 chunks +0 lines, -37 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/handle.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/dart/element/element_test.dart View 1 chunk +0 lines, -75 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 3 months ago (2016-09-13 01:02:51 UTC) #1
Brian Wilkerson
lgtm
4 years, 3 months ago (2016-09-13 13:43:50 UTC) #2
scheglov
4 years, 3 months ago (2016-09-13 14:46:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8c1d5a3b56215a334b79c6af98efaf87d142e75c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698