Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2336903004:
Re-enable disabled geolocation browser tests on Linux. (Closed)
|
Created:
4 years, 3 months ago by dominickn Modified:
4 years, 3 months ago Reviewers:
Michael van Ouwerkerk CC:
chromium-reviews, mlamouri+watch-geolocation_chromium.org, Michael van Ouwerkerk Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRe-enable disabled geolocation browser tests on Linux.
These were disabled ~12 months ago for being flaky. 50 runs
through the linux_chromium_rel_ng trybot revealed no flakiness.
BUG=527437
Committed: https://crrev.com/d5094b3a3aa1cc723ff8ed7cf364146d5e9f73bf
Cr-Commit-Position: refs/heads/master@{#419068}
Patch Set 1 #Patch Set 2 : Rebase #
Depends on Patchset: Messages
Total messages: 20 (15 generated)
dominickn@chromium.org changed reviewers: + mvanouwerkerk@chromium.org
Hi Michael, I ran into crbug.com/527437 whilst adding some new geolocation browser tests (that I will send to you for review shortly). This CL reenables all of the disabled tests; running it through the linux builders 50 times didn't reveal any flakes (the purple runs are me mistyping the bot name). It might be that whatever the underlying issue was has gone away. WDYT about landing?
Description was changed from ========== Re-enable disabled geolocation browser tests on Linux. These were disabled ~12 months ago for being flaky. BUG=527437 ========== to ========== Re-enable disabled geolocation browser tests on Linux. These were disabled ~12 months ago for being flaky. 50 runs through the linux_chromium_rel_ng trybot revealed no flakiness. BUG=527437 ==========
Description was changed from ========== Re-enable disabled geolocation browser tests on Linux. These were disabled ~12 months ago for being flaky. 50 runs through the linux_chromium_rel_ng trybot revealed no flakiness. BUG=527437 ========== to ========== Re-enable disabled geolocation browser tests on Linux. These were disabled ~12 months ago for being flaky. 50 runs through the linux_chromium_rel_ng trybot revealed no flakiness. BUG=527437 ==========
lgtm Thanks!
The CQ bit was checked by mvanouwerkerk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dominickn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dominickn@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mvanouwerkerk@chromium.org Link to the patchset: https://codereview.chromium.org/2336903004/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Re-enable disabled geolocation browser tests on Linux. These were disabled ~12 months ago for being flaky. 50 runs through the linux_chromium_rel_ng trybot revealed no flakiness. BUG=527437 ========== to ========== Re-enable disabled geolocation browser tests on Linux. These were disabled ~12 months ago for being flaky. 50 runs through the linux_chromium_rel_ng trybot revealed no flakiness. BUG=527437 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Re-enable disabled geolocation browser tests on Linux. These were disabled ~12 months ago for being flaky. 50 runs through the linux_chromium_rel_ng trybot revealed no flakiness. BUG=527437 ========== to ========== Re-enable disabled geolocation browser tests on Linux. These were disabled ~12 months ago for being flaky. 50 runs through the linux_chromium_rel_ng trybot revealed no flakiness. BUG=527437 Committed: https://crrev.com/d5094b3a3aa1cc723ff8ed7cf364146d5e9f73bf Cr-Commit-Position: refs/heads/master@{#419068} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d5094b3a3aa1cc723ff8ed7cf364146d5e9f73bf Cr-Commit-Position: refs/heads/master@{#419068} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
