mash: Port context menu code to WmShell and WmRootWindowController.

mash: Port context menu code to WmShell and WmRootWindowController.

BUG=640693
TEST=Context menus show up for the wallpaper and shelf.
R=sky@chromium.org

Committed: https://crrev.com/20734f8bc75635b1cf93c7cd9a4333e207041623
Cr-Commit-Position: refs/heads/master@{#418263}

[msw, 2016-09-13 01:12:51]

Description was changed from

==========
mash: Port context menu code to WmShell and WmRootWindowController.

BUG=640693
==========

to

==========
mash: Port context menu code to WmShell and WmRootWindowController.

BUG=640693
TEST=Context menus show up for the wallpaper and shelf.
R=sky@chromium.org
==========

[msw, 2016-09-13 01:12:51]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-09-13 01:13:09]

Hey Scott, please take a look; thanks!

[msw, 2016-09-13 01:13:58]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 01:14:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 01:16:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 01:17:00]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[msw, 2016-09-13 01:33:08]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 01:33:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-09-13 01:44:10]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 01:44:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-09-13 02:12:53]

I realize you're just moving code, but ShowContextMenu on RootWindowController
and Shell is a very generic name for those classes. How about
ShowShelfContextMenu?

[commit-bot: I haz the power, 2016-09-13 02:25:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 02:25:23]

Dry run: This issue passed the CQ dry run.

[msw, 2016-09-13 06:03:27]

On 2016/09/13 02:12:53, sky wrote:
> I realize you're just moving code, but ShowContextMenu on RootWindowController
> and Shell is a very generic name for those classes. How about
> ShowShelfContextMenu?

The same context menu is shown for the desktop background wallpaper, and
includes both shelf and wallpaper options. Thoughts?

[sky, 2016-09-13 13:13:00]

ShowContextMenu it is then. LGTM

[msw, 2016-09-13 16:04:01]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-09-13 16:04:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 16:09:14]

Description was changed from

==========
mash: Port context menu code to WmShell and WmRootWindowController.

BUG=640693
TEST=Context menus show up for the wallpaper and shelf.
R=sky@chromium.org
==========

to

==========
mash: Port context menu code to WmShell and WmRootWindowController.

BUG=640693
TEST=Context menus show up for the wallpaper and shelf.
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-09-13 16:09:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-13 16:10:51]

Description was changed from

==========
mash: Port context menu code to WmShell and WmRootWindowController.

BUG=640693
TEST=Context menus show up for the wallpaper and shelf.
R=sky@chromium.org
==========

to

==========
mash: Port context menu code to WmShell and WmRootWindowController.

BUG=640693
TEST=Context menus show up for the wallpaper and shelf.
R=sky@chromium.org

Committed: https://crrev.com/20734f8bc75635b1cf93c7cd9a4333e207041623
Cr-Commit-Position: refs/heads/master@{#418263}
==========

[commit-bot: I haz the power, 2016-09-13 16:10:52]

Patchset 4 (id:??) landed as
https://crrev.com/20734f8bc75635b1cf93c7cd9a4333e207041623
Cr-Commit-Position: refs/heads/master@{#418263}