chrome/browser/chromeos/extensions/users_private/users_private_api.cc - Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/users_private/users_private_api.cc

Issue 2336863003: Change more base::ListValue methods to use std::unique_ptr. (Closed)

Patch Set: CrOS fixes + address danakj comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/values.cc ('k') | chrome/browser/chromeos/login/existing_user_controller_browsertest.cc » ('j') | chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/users_private/users_private_api.cc

diff --git a/chrome/browser/chromeos/extensions/users_private/users_private_api.cc b/chrome/browser/chromeos/extensions/users_private/users_private_api.cc

index 807498cebdef615a097fed624dd1aea3d3e687e7..ab0e4404a518f16b02b483bdc21cebcaab69f7ee 100644

--- a/chrome/browser/chromeos/extensions/users_private/users_private_api.cc

+++ b/chrome/browser/chromeos/extensions/users_private/users_private_api.cc

@@ -84,9 +84,9 @@ UsersPrivateGetWhitelistedUsersFunction::Run() {

user_manager::UserManager* user_manager = user_manager::UserManager::Get();

const user_manager::UserList& users = user_manager->GetUsers();

- for (user_manager::UserList::const_iterator it = users.begin();

- it < users.end(); ++it)

- email_list->AppendIfNotPresent(new base::StringValue((*it)->email()));

+ for (const auto& user : users)

danakj 2016/09/14 01:55:59 {}

dcheng 2016/09/14 03:06:11 Done.

+ email_list->AppendIfNotPresent(

+ base::MakeUnique<base::StringValue>(user->email()));

if (chromeos::OwnerSettingsServiceChromeOS* service =

chromeos::OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(