extensions/browser/guest_view/extension_view/whitelist/BUILD.gn - Issue 2336843002: Decompose //extensions/browser/BUILD.gn

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/browser/guest_view/extension_view/whitelist/BUILD.gn

Issue 2336843002: Decompose //extensions/browser/BUILD.gn (Closed)

Patch Set: fix moar dependencies. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//mojo/public/tools/bindings/mojom.gni")	5 source_set("whitelist") {
	Rahul Chaturvedi 2016/09/13 22:48:52 This is a newly added file. Not sure why the code This is a newly added file. Not sure why the code review tool is showing differently.
6

7 mojom("interfaces") {

8 sources = [	6 sources = [

9 "catalog.mojom",	7 "extension_view_whitelist.cc",
Rahul Chaturvedi 2016/09/13 22:48:52 I have no idea where this came from. Rietveld fail I have no idea where this came from. Rietveld fail. brettw 2016/09/13 23:13:09 This is git trying to track moved+modified files. Show quoted text On 2016/09/13 22:48:52, Rahul Chaturvedi wrote: > I have no idea where this came from. Rietveld fail. This is git trying to track moved+modified files.
	8 "extension_view_whitelist.h",

10 ]	9 ]

11 }	10 }

OLD	NEW