extensions/browser/api/webcam_private/BUILD.gn - Issue 2336843002: Decompose //extensions/browser/BUILD.gn

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/browser/api/webcam_private/BUILD.gn

Issue 2336843002: Decompose //extensions/browser/BUILD.gn (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 assert(is_chromeos)
	Devlin 2016/09/15 00:08:04 nit: do we have to import anything to use is_chrom nit: do we have to import anything to use is_chromeos? Rahul Chaturvedi 2016/09/15 00:14:57 Nope. It is available without any imports, in fact Show quoted text On 2016/09/15 00:08:04, Devlin wrote: > nit: do we have to import anything to use is_chromeos? Nope. It is available without any imports, in fact, all is_platform variables seem to be used without imports everywhere.
	6

	7 source_set("webcam_private") {

	8 sources = [

	9 "v4l2_webcam.cc",

	10 "v4l2_webcam.h",

	11 "visca_webcam.cc",

	12 "visca_webcam.h",

	13 "webcam.cc",

	14 "webcam.h",

	15 "webcam_private_api.h",

	16 "webcam_private_api_chromeos.cc",

	17 ]

	18

	19 deps = [

	20 "//extensions/common/api",

	21 ]

	22 }

OLD	NEW