extensions/browser/api/messaging/BUILD.gn - Issue 2336843002: Decompose //extensions/browser/BUILD.gn

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/browser/api/messaging/BUILD.gn

Issue 2336843002: Decompose //extensions/browser/BUILD.gn (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 source_set("webui") {	5 source_set("messaging") {

6 sources = [	6 sources = [

7 "physical_web_ui_constants.cc",	7 "native_message_host.cc",
	Devlin 2016/09/14 22:50:29 what about the .h? (I think this was probably a bu what about the .h? (I think this was probably a bug in the gypi) Rahul Chaturvedi 2016/09/14 23:10:24 Yep, was broken in the original BUILD.gn. Fixed an Show quoted text On 2016/09/14 22:50:29, Devlin wrote: > what about the .h? (I think this was probably a bug in the gypi) Yep, was broken in the original BUILD.gn. Fixed and added the other missing header.
8 "physical_web_ui_constants.h",

9 ]	8 ]

10	9

11 deps = [	10 deps = [

12 "//base",	11 "//extensions/common/api",

13 ]	12 ]

14 }	13 }

OLD	NEW