extensions/browser/api/document_scan/BUILD.gn - Issue 2336843002: Decompose //extensions/browser/BUILD.gn

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/browser/api/document_scan/BUILD.gn

Issue 2336843002: Decompose //extensions/browser/BUILD.gn (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 source_set("document_scan") {

	6 sources = [

	7 "document_scan_api.cc",

	8 "document_scan_api.h",

	9 "document_scan_interface.cc",

	10 "document_scan_interface.h",

	11 "document_scan_interface_chromeos.cc",
	Devlin 2016/09/14 22:50:29 this seems broken - why do we include chromeos whe this seems broken - why do we include chromeos when line 14 implies that nonchromeos is possible here? Rahul Chaturvedi 2016/09/14 23:10:24 _chromeos files will only be compiled on Chrome OS Show quoted text On 2016/09/14 22:50:29, Devlin wrote: > this seems broken - why do we include chromeos when line 14 implies that > nonchromeos is possible here? _chromeos files will only be compiled on Chrome OS. This is also how the original build was setup, my parser just moved it. This could 'maybe' be done better, but is definitely not in the scope of this CL. Devlin 2016/09/15 00:08:04 Ah, didn't realize we had that rule. Interesting! Show quoted text On 2016/09/14 23:10:24, Rahul Chaturvedi wrote: > On 2016/09/14 22:50:29, Devlin wrote: > > this seems broken - why do we include chromeos when line 14 implies that > > nonchromeos is possible here? > > _chromeos files will only be compiled on Chrome OS. This is also how the > original build was setup, my parser just moved it. This could 'maybe' be done > better, but is definitely not in the scope of this CL. Ah, didn't realize we had that rule. Interesting!
	12 ]

	13

	14 if (!is_chromeos) {

	15 sources += [ "document_scan_interface_nonchromeos.cc" ]

	16 }

	17

	18 deps = [

	19 "//extensions/common/api",

	20 ]

	21 }

OLD	NEW