Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 2336803003: Make SyntheticPointerAction to flush the pointer action sequence (Closed)
Patch Set: controller Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index 3d71e22532d640f4f65e849d0dd4ad61b409b6fc..c7e021a64d9946239f7466bd299c41707b358e9a 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -1190,6 +1190,19 @@ void RenderWidgetHostImpl::QueueSyntheticGesture(
}
}
+void RenderWidgetHostImpl::QueueSyntheticGesture(
+ const SyntheticGestureParams& gesture_params,
+ const base::Callback<void(SyntheticGesture::Result)>& on_complete) {
+ if (!synthetic_gesture_controller_ && view_) {
+ synthetic_gesture_controller_.reset(
+ new SyntheticGestureController(view_->CreateSyntheticGestureTarget()));
+ }
+ if (synthetic_gesture_controller_) {
+ synthetic_gesture_controller_->QueueSyntheticPointerAction(gesture_params,
+ on_complete);
+ }
+}
+
void RenderWidgetHostImpl::SetCursor(const WebCursor& cursor) {
if (!view_)
return;
@@ -1744,9 +1757,9 @@ void RenderWidgetHostImpl::OnQueueSyntheticGesture(
}
QueueSyntheticGesture(
- SyntheticGesture::Create(*gesture_packet.gesture_params()),
- base::Bind(&RenderWidgetHostImpl::OnSyntheticGestureCompleted,
- weak_factory_.GetWeakPtr()));
tdresser 2016/09/30 13:24:30 Why did we stop doing things this way? Perhaps the
+ *gesture_packet.gesture_params(),
+ base::Bind(&RenderWidgetHostImpl::OnSyntheticGestureCompleted,
+ weak_factory_.GetWeakPtr()));
}
void RenderWidgetHostImpl::OnSetCursor(const WebCursor& cursor) {
@@ -2019,6 +2032,8 @@ void RenderWidgetHostImpl::OnUnexpectedEventAck(UnexpectedEventAckType type) {
void RenderWidgetHostImpl::OnSyntheticGestureCompleted(
SyntheticGesture::Result result) {
+ LOG(ERROR) << "RenderWidgetHostImpl::OnSyntheticGestureCompleted "
+ << (int)result;
tdresser 2016/09/30 13:24:30 Remove log.
lanwei 2016/10/21 21:53:07 Done.
Send(new InputMsg_SyntheticGestureCompleted(GetRoutingID()));
}

Powered by Google App Engine
This is Rietveld 408576698