Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: content/browser/renderer_host/input/synthetic_mouse_driver.cc

Issue 2336803003: Make SyntheticPointerAction to flush the pointer action sequence (Closed)
Patch Set: return invaid when index is out bound Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/synthetic_mouse_driver.cc
diff --git a/content/browser/renderer_host/input/synthetic_mouse_driver.cc b/content/browser/renderer_host/input/synthetic_mouse_driver.cc
index 82dcbdd8a413df55d939127dc47de124f90d9822..2541388d63b25a097571488efc2975c4e8b22b6c 100644
--- a/content/browser/renderer_host/input/synthetic_mouse_driver.cc
+++ b/content/browser/renderer_host/input/synthetic_mouse_driver.cc
@@ -18,11 +18,10 @@ void SyntheticMouseDriver::DispatchEvent(SyntheticGestureTarget* target,
target->DispatchInputEventToPlatform(mouse_event_);
}
-int SyntheticMouseDriver::Press(float x, float y) {
+void SyntheticMouseDriver::Press(float x, float y, int index) {
mouse_event_ = SyntheticWebMouseEventBuilder::Build(
tdresser 2016/12/12 15:32:49 Why did we switch from returning the index to pass
tdresser 2016/12/13 14:37:43 Acknowledged.
blink::WebInputEvent::MouseDown, x, y, 0);
mouse_event_.clickCount = 1;
- return 0;
}
void SyntheticMouseDriver::Move(float x, float y, int index) {
@@ -44,7 +43,7 @@ void SyntheticMouseDriver::Release(int index) {
bool SyntheticMouseDriver::UserInputCheck(
const SyntheticPointerActionParams& params) const {
- if (params.gesture_source_type != SyntheticGestureParams::MOUSE_INPUT)
+ if (params.gesture_source_type() != SyntheticGestureParams::MOUSE_INPUT)
return false;
if (params.pointer_action_type() ==

Powered by Google App Engine
This is Rietveld 408576698