Cleanup of isolate.status (first step)

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 337 matching lines @@
       String constructedName = '$suiteName/$testPrefix$testName';
       if (!pattern.hasMatch(constructedName)) return;
 
       var expectations = testExpectations.expectations(
           '$testPrefix$testName');
 
       if (configuration["report"]) {
         SummaryReport.add(expectations);
       }
 
-      if (expectations.contains(SKIP)) return;
+      if (expectations.contains(SKIP) ||
+          expectations.contains(SKIP_BY_DESIGN)) {
+        return;
+      }
 
       var args = TestUtils.standardOptions(configuration);
       args.add(testName);
 
       var command = CommandBuilder.instance.getCommand(
           'run_vm_unittest', targetRunnerPath, args, configurationDir);
       doTest(
           new TestCase(constructedName,
                        [command],
                        configuration,
@@ skipping 307 matching lines @@
         configuration['report']) {
       SummaryReport.addCompileErrorSkipTest();
       return;
     }
     if (configuration['report']) {
       // Tests with multiple VMOptions are counted more than once.
       for (var dummy in getVmOptions(optionsFromFile)) {
         SummaryReport.add(expectations);
       }
     }
-    if (expectations.contains(SKIP)) return;
+    if (expectations.contains(SKIP) ||
+        expectations.contains(SKIP_BY_DESIGN)) {
+      return;
+    }
 
     if (configuration['compiler'] != 'none' && info.hasCompileError) {
       // If a compile-time error is expected, and we're testing a
       // compiler, we never need to attempt to run the program (in a
       // browser or otherwise).
       enqueueStandardTest(info, testName, expectations);
     } else if (TestUtils.isBrowserRuntime(configuration['runtime'])) {
       bool isWrappingRequired = configuration['compiler'] != 'dart2js';
       if (info.optionsFromFile['isMultiHtmlTest']) {
         // A browser multi-test has multiple expectations for one test file.
@@ skipping 1203 matching lines @@
     }
     return extraVmOptions;
   }
 
 
 }
 
 class SummaryReport {
   static int total = 0;
   static int skipped = 0;
+  static int skippedByDesign = 0;
   static int noCrash = 0;
   static int pass = 0;
   static int failOk = 0;
   static int fail = 0;
   static int crash = 0;
   static int timeout = 0;
   static int compileErrorSkip = 0;
 
   static void add(Set<String> expectations) {
     ++total;
     if (expectations.contains(SKIP)) {
       ++skipped;
+    } else if (expectations.contains(SKIP_BY_DESIGN)) {
+      ++skipped;
+      ++skippedByDesign;
     } else {
       if (expectations.contains(PASS) && expectations.contains(FAIL) &&
           !expectations.contains(CRASH) && !expectations.contains(OK)) {
         ++noCrash;
       }
       if (expectations.contains(PASS) && expectations.length == 1) {
         ++pass;
       }
       if (expectations.containsAll([FAIL, OK]) && expectations.length == 2) {
         ++failOk;
@@ skipping 11 matching lines @@
   }
 
   static void addCompileErrorSkipTest() {
     total++;
     compileErrorSkip++;
   }
 
   static void printReport() {
     if (total == 0) return;
     String report = """Total: $total tests
- * $skipped tests will be skipped
+ * $skipped tests will be skipped ($skippedByDesign skipped by design)
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
  * $compileErrorSkip tests are skipped on browsers due to compile-time error
 """;
     print(report);
    }
 }