src/gpu/vk/GrVkGpuCommandBuffer.h - Issue 2336763002: Lots of little cleanup improvements to Vulkan

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/gpu/vk/GrVkGpuCommandBuffer.h

Issue 2336763002: Lots of little cleanup improvements to Vulkan (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright 2016 Google Inc.	2 * Copyright 2016 Google Inc.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license that can be	4 * Use of this source code is governed by a BSD-style license that can be

5 * found in the LICENSE file.	5 * found in the LICENSE file.

6 */	6 */

7	7

8 #ifndef GrVkGpuCommandBuffer_DEFINED	8 #ifndef GrVkGpuCommandBuffer_DEFINED

9 #define GrVkGpuCommandBuffer_DEFINED	9 #define GrVkGpuCommandBuffer_DEFINED

10	10

(...skipping 45 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
56	56

57 void onClearStencilClip(GrRenderTarget*, const GrFixedClip&, bool insideSten cilMask) override;	57 void onClearStencilClip(GrRenderTarget*, const GrFixedClip&, bool insideSten cilMask) override;

58	58

59 const GrVkRenderPass* fRenderPass;	59 const GrVkRenderPass* fRenderPass;

60 GrVkSecondaryCommandBuffer* fCommandBuffer;	60 GrVkSecondaryCommandBuffer* fCommandBuffer;

61 GrVkGpu* fGpu;	61 GrVkGpu* fGpu;

62 GrVkRenderTarget* fRenderTarget;	62 GrVkRenderTarget* fRenderTarget;

63 VkClearValue fColorClearValue;	63 VkClearValue fColorClearValue;

64	64

65 bool fIsEmpty;	65 bool fIsEmpty;

	66 bool fHasClearStart;
	jvanverth1 2016/09/12 20:48:23 This sounds like it didn't foul on the starting li This sounds like it didn't foul on the starting line. fStartsWithClear, maybe? Also seems to always be false. egdaniel 2016/09/12 21:14:32 Done. And forgot to save/commit the change that se Show quoted text On 2016/09/12 20:48:23, jvanverth1 wrote: > This sounds like it didn't foul on the starting line. fStartsWithClear, maybe? > Also seems to always be false. Done. And forgot to save/commit the change that set this...
66	67

67 typedef GrGpuCommandBuffer INHERITED;	68 typedef GrGpuCommandBuffer INHERITED;

68 };	69 };

69	70

70 #endif	71 #endif

OLD	NEW

« no previous file with comments | « src/gpu/vk/GrVkGpu.cpp ('k') | src/gpu/vk/GrVkGpuCommandBuffer.cpp » ('j') | src/gpu/vk/GrVkGpuCommandBuffer.cpp » ('J')