Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: src/objects.cc

Issue 233673007: Drop unused name parameter of SetPropertyToField(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index f66275a3ae46d1f802db1e313190d11a6b201698..789bfaf7fa1afd5da66806860e08bee0b0859f29 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -4020,7 +4020,6 @@ MaybeHandle<Object> JSObject::SetPropertyUsingTransition(
static void SetPropertyToField(LookupResult* lookup,
- Handle<Name> name,
Handle<Object> value) {
Representation representation = lookup->representation();
if (!lookup->CanHoldValue(value) ||
@@ -4083,7 +4082,7 @@ static void SetPropertyToFieldWithAttributes(LookupResult* lookup,
PropertyAttributes attributes) {
if (lookup->GetAttributes() == attributes) {
if (value->IsUninitialized()) return;
- SetPropertyToField(lookup, name, value);
+ SetPropertyToField(lookup, value);
} else {
ConvertAndSetLocalProperty(lookup, name, value, attributes);
}
@@ -4178,12 +4177,12 @@ MaybeHandle<Object> JSObject::SetPropertyForResult(
SetNormalizedProperty(handle(lookup->holder()), lookup, value);
break;
case FIELD:
- SetPropertyToField(lookup, name, value);
+ SetPropertyToField(lookup, value);
break;
case CONSTANT:
// Only replace the constant if necessary.
if (*value == lookup->GetConstant()) return value;
- SetPropertyToField(lookup, name, value);
+ SetPropertyToField(lookup, value);
break;
case CALLBACKS: {
Handle<Object> callback_object(lookup->GetCallbackObject(), isolate);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698