Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: pkg/code_transformers/lib/src/resolver_impl.dart

Issue 233673003: Deal better with missing sources in code_transformers and polymer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/code_transformers/test/resolver_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/code_transformers/lib/src/resolver_impl.dart
diff --git a/pkg/code_transformers/lib/src/resolver_impl.dart b/pkg/code_transformers/lib/src/resolver_impl.dart
index ad73da401ae44cc2fc5e5ee674626b26234b44e1..c6be747d03ebcb7d2257b37579b6fe141fd95f63 100644
--- a/pkg/code_transformers/lib/src/resolver_impl.dart
+++ b/pkg/code_transformers/lib/src/resolver_impl.dart
@@ -136,6 +136,8 @@ class ResolverImpl implements Resolver {
_context.applyChanges(
new ChangeSet()..removedSource(source));
sources[assetId].updateContents(null);
+ } else if (source == null) {
+ transform.logger.warning('Asset not found: $assetId');
Siggi Cherem (dart-lang) 2014/04/10 20:05:47 we already compute the span inside dependentsAsset
}
}));
}
@@ -159,8 +161,11 @@ class ResolverImpl implements Resolver {
_context.applyChanges(changeSet);
// Force resolve each entry point (the getter will ensure the library is
// computed first).
- _entryLibraries = entryPoints
- .map((id) => _context.computeLibraryElement(sources[id])).toList();
+ _entryLibraries = entryPoints.map((id) {
+ var source = sources[id];
+ if (source == null) return null;
+ return _context.computeLibraryElement(source);
+ }).toList();
});
}
« no previous file with comments | « no previous file | pkg/code_transformers/test/resolver_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698