Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2336723002: Remove base class for installed transforms in GrPrimitiveProcessor (Closed)

Created:
4 years, 3 months ago by bsalomon
Modified:
4 years, 3 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove base class for installed transforms in GrPrimitiveProcessor GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336723002 Committed: https://skia.googlesource.com/skia/+/790c90b20e4e28f19e3e2a73d5f9315980fd45c1

Patch Set 1 #

Patch Set 2 : rm unused type field for glsl geo proc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -14 lines) Patch
M src/gpu/GrPathProcessor.cpp View 1 2 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/glsl/GrGLSLGeometryProcessor.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/glsl/GrGLSLPrimitiveProcessor.h View 1 chunk +0 lines, -6 lines 0 comments Download

Dependent Patchsets:

Issue 2338453002 Patch 1

Messages

Total messages: 12 (8 generated)
bsalomon
4 years, 3 months ago (2016-09-12 18:53:23 UTC) #3
egdaniel
lgtm
4 years, 3 months ago (2016-09-12 19:24:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336723002/20001
4 years, 3 months ago (2016-09-12 19:55:44 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 19:57:01 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/790c90b20e4e28f19e3e2a73d5f9315980fd45c1

Powered by Google App Engine
This is Rietveld 408576698