third_party/WebKit/Source/core/dom/Document.cpp - Issue 2336693002: Rendering text to a canvas in a frame-less document.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2336693002: Rendering text to a canvas in a frame-less document. (Closed)

Patch Set: Addressing comments from patch set 1. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index 19a0e0def294cb5053921d7d5bb703e3e5fb2cef..739e80bde553a947bad6b7e5b611c1b2ac21e700 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -1422,7 +1422,11 @@ FrameHost* Document::frameHost() const

Settings* Document::settings() const

{

- return m_frame ? m_frame->settings() : nullptr;

+ if (m_frame)

+ return m_frame->settings();

+ if (!m_defaultSettings)

+ m_defaultSettings = Settings::create();

+ return m_defaultSettings.get();

}

Range* Document::createRange()