Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 233663002: Update bench to be able to preprocess skps (Closed)

Created:
6 years, 8 months ago by robertphillips
Modified:
6 years, 8 months ago
Reviewers:
jvanverth1, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Update bench to be able to preprocess skps This allows benchmarking of optimization improvements and plumbs in the purging API. The purging is necessary so we don't magically get faster because the saveLayers are always pre-generated. Committed: http://code.google.com/p/skia/source/detail?r=14154

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : add missing file #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -5 lines) Patch
M include/core/SkCanvas.h View 1 chunk +6 lines, -0 lines 0 comments Download
M include/core/SkDevice.h View 2 chunks +8 lines, -1 line 0 comments Download
M include/gpu/SkGpuDevice.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +8 lines, -1 line 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 1 chunk +5 lines, -1 line 2 comments Download
M tools/PictureBenchmark.h View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/PictureBenchmark.cpp View 1 3 chunks +20 lines, -0 lines 0 comments Download
M tools/bench_pictures_main.cpp View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
robertphillips
6 years, 8 months ago (2014-04-10 19:30:19 UTC) #1
jvanverth1
https://codereview.chromium.org/233663002/diff/40001/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/233663002/diff/40001/src/gpu/SkGpuDevice.cpp#newcode1926 src/gpu/SkGpuDevice.cpp:1926: It's not clear to me where the SkCanvas* gets ...
6 years, 8 months ago (2014-04-10 20:23:34 UTC) #2
robertphillips
https://codereview.chromium.org/233663002/diff/40001/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/233663002/diff/40001/src/gpu/SkGpuDevice.cpp#newcode1926 src/gpu/SkGpuDevice.cpp:1926: This is a small, salvageable chunk of my check-that-pre-rendering-saveLayers-is-worth-it ...
6 years, 8 months ago (2014-04-11 11:09:06 UTC) #3
jvanverth1
lgtm
6 years, 8 months ago (2014-04-11 12:44:16 UTC) #4
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 8 months ago (2014-04-11 13:15:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/233663002/40001
6 years, 8 months ago (2014-04-11 13:15:59 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 13:16:23 UTC) #7
commit-bot: I haz the power
Presubmit check for 233663002-40001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 8 months ago (2014-04-11 13:16:23 UTC) #8
robertphillips
+Mike for API
6 years, 8 months ago (2014-04-11 13:20:29 UTC) #9
reed1
lgtm
6 years, 8 months ago (2014-04-11 14:43:30 UTC) #10
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 8 months ago (2014-04-11 14:44:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/233663002/40001
6 years, 8 months ago (2014-04-11 14:44:34 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 15:54:18 UTC) #13
Message was sent while issue was closed. 
Change committed as 14154

Powered by Google App Engine
This is Rietveld 408576698