Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2336623002: Match Android framework's non-AA point and line offset (Closed)

Created:
4 years, 3 months ago by bsalomon
Modified:
4 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Match Android framework's non-AA point and line offset GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336623002 Committed: https://skia.googlesource.com/skia/+/6ade6dd9910be25c15e25c90d76f8471ff23f62c

Patch Set 1 #

Patch Set 2 : attempt 2 #

Patch Set 3 : Make android framework only #

Patch Set 4 : more #

Total comments: 2

Patch Set 5 : fix speeling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 2 chunks +24 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
bsalomon
4 years, 3 months ago (2016-09-12 17:13:28 UTC) #4
robertphillips
lgtm https://codereview.chromium.org/2336623002/diff/60001/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/2336623002/diff/60001/src/gpu/SkGpuDevice.cpp#newcode349 src/gpu/SkGpuDevice.cpp:349: PrimtiveType - missing 'i' ?
4 years, 3 months ago (2016-09-12 17:16:51 UTC) #5
bsalomon
https://codereview.chromium.org/2336623002/diff/60001/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/2336623002/diff/60001/src/gpu/SkGpuDevice.cpp#newcode349 src/gpu/SkGpuDevice.cpp:349: On 2016/09/12 17:16:51, robertphillips wrote: > PrimtiveType - missing ...
4 years, 3 months ago (2016-09-12 17:59:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336623002/80001
4 years, 3 months ago (2016-09-12 17:59:24 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 19:07:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/6ade6dd9910be25c15e25c90d76f8471ff23f62c

Powered by Google App Engine
This is Rietveld 408576698