glTexStorage requires sized formats, ensure that we're following that rule

glTexStorage requires sized formats, ensure that we're following that rule

In some situations (at least ANGLE ES3), we were passing GL_BGRA, rather
than GL_BGRA8.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336613002

Committed: https://skia.googlesource.com/skia/+/81a8485997162a6f2bef84b1130033b1222c722c

[Brian Osman, 2016-09-12 15:04:08]

Description was changed from

==========
glTexStorage requires sized formats, ensure that we're following that rule

In some situations (at least ANGLE ES3), we were passing GL_BGRA, rather
than GL_BGRA8.

BUG=skia:
==========

to

==========
glTexStorage requires sized formats, ensure that we're following that rule

In some situations (at least ANGLE ES3), we were passing GL_BGRA, rather
than GL_BGRA8.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336613002
==========

[Brian Osman, 2016-09-12 15:05:55]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 15:06:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Brian Osman, 2016-09-12 15:08:16]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, geofflang@google.com, robertphillips@google.com

[Brian Osman, 2016-09-12 15:08:17]

Thanks to Geoff for noticing this while investigating our ES3 issues.

https://codereview.chromium.org/2336613002/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/2336613002/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:996: GrGLenum sizedInternalFormat,
FWIW: Don't think we need to change allocate_and_populate_compressed_texture,
because all compressed internal formats are also sized.

[bsalomon, 2016-09-12 15:14:55]

https://codereview.chromium.org/2336613002/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/2336613002/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:996: GrGLenum sizedInternalFormat,
On 2016/09/12 15:08:17, Brian Osman wrote:
> FWIW: Don't think we need to change allocate_and_populate_compressed_texture,
> because all compressed internal formats are also sized.

My only hesitation here is that calling this sizedInternalFormat makes it seem
as though the param internalFormat is unsized, which it may not be.  Could we
call it something like storageInternalFormat or internalFormatForTexStorage?

[Brian Osman, 2016-09-12 15:23:53]

Renamed the variable, and added some comments to explain what's going on.

[bsalomon, 2016-09-12 15:28:13]

lgtm

[Brian Osman, 2016-09-12 15:31:14]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-09-12 15:31:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 16:05:20]

Description was changed from

==========
glTexStorage requires sized formats, ensure that we're following that rule

In some situations (at least ANGLE ES3), we were passing GL_BGRA, rather
than GL_BGRA8.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336613002
==========

to

==========
glTexStorage requires sized formats, ensure that we're following that rule

In some situations (at least ANGLE ES3), we were passing GL_BGRA, rather
than GL_BGRA8.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336613002

Committed:
https://skia.googlesource.com/skia/+/81a8485997162a6f2bef84b1130033b1222c722c
==========

[commit-bot: I haz the power, 2016-09-12 16:05:22]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/81a8485997162a6f2bef84b1130033b1222c722c