Issue 233653006: Unify event handler tracking tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 233653006: Unify event handler tracking tests (Closed)

Created:
6 years, 8 months ago by Sami

Modified:
6 years, 3 months ago

Reviewers:
Ian Vollick, Rick Byers, abarth-chromium

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Unify event handler tracking tests Now that wheel, scroll and touch events are all tracked by common code in EventHandlerRegistry, we can unify the related tests into a more focused generic test. See https://codereview.chromium.org/206603002/ for full review history. BUG=347366

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -508 lines)			Patch
A +	LayoutTests/fast/events/event-handler-count.html	View	5 chunks	+47 lines, -39 lines	0 comments	Download
A +	LayoutTests/fast/events/event-handler-count-expected.txt	View	4 chunks	+23 lines, -18 lines	0 comments	Download
D	LayoutTests/fast/events/touch/touch-handler-count.html	View	1 chunk	+0 lines, -260 lines	0 comments	Download
D	LayoutTests/fast/events/touch/touch-handler-count-expected.txt	View	1 chunk	+0 lines, -93 lines	0 comments	Download
D	LayoutTests/fast/events/wheelevent-handler-count.html	View	1 chunk	+0 lines, -69 lines	0 comments	Download
D	LayoutTests/fast/events/wheelevent-handler-count-expected.txt	View	1 chunk	+0 lines, -29 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sami

6 years, 8 months ago (2014-04-15 10:19:20 UTC) #3

Thanks Rick.

Note to self: upload a rebased version that also deletes
scroll-event-handler-count{.html,-expected.txt} since rietveld doesn't like
patches that delete non-existent files.

Expand Messages | Collapse Messages