Issue 233653002: x11: Remove MessagePumpObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 233653002: x11: Remove MessagePumpObserver. (Closed)

Created:
6 years, 8 months ago by sadrul

Modified:
6 years, 8 months ago

Reviewers:
darin (slow to review), sky

CC:
chromium-reviews, ben+aura_chromium.org, dcheng, oshima+watch_chromium.org, kalyank, erikwright+watch_chromium.org, stevenjb+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

x11: Remove MessagePumpObserver. Convert the last ramining instances of MessagePumpObservers into PlatformEventObservers, and remove support for MessagePumpObservers from non-Windows platforms. BUG=354062 R=sky@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263158

Patch Set 1 #

Patch Set 2 : . #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -109 lines)			Patch
M	base/message_loop/message_loop.h	View		2 chunks	+3 lines, -6 lines	0 comments	Download
M	base/message_loop/message_loop.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	base/message_loop/message_pump_observer.h	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	base/message_loop/message_pump_x11.h	View		2 chunks	+0 lines, -27 lines	0 comments	Download
M	base/message_loop/message_pump_x11.cc	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	ui/aura/window_tree_host_x11.cc	View	1	6 chunks	+9 lines, -8 lines	0 comments	Download
M	ui/base/clipboard/clipboard_aurax11.cc	View		5 chunks	+9 lines, -11 lines	0 comments	Download
M	ui/display/chromeos/x11/native_display_delegate_x11.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/display/chromeos/x11/native_display_delegate_x11.cc	View		6 chunks	+28 lines, -24 lines	0 comments	Download
M	ui/events/platform/x11/x11_event_source.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sadrul

Please feel free to add additional reviewers as you see fit. The next steps are ...

6 years, 8 months ago (2014-04-10 19:34:22 UTC) #1

sadrul

Committed patchset #2 manually as r263158 (presubmit successful).

6 years, 8 months ago (2014-04-11 03:02:35 UTC) #3

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages