Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 2336503003: fix #25578, implement @covariant parameter overrides (Closed)
Patch Set: fix comments, format Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/error_verifier.dart ('k') | pkg/analyzer/lib/src/generated/type_system.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart
index 4f99160925a80b62af7953f4b5852250e7efcd5d..ca8887c2d50896d4e589a71100f4019b2adf689a 100644
--- a/pkg/analyzer/lib/src/generated/resolver.dart
+++ b/pkg/analyzer/lib/src/generated/resolver.dart
@@ -533,8 +533,8 @@ class BestPracticesVerifier extends RecursiveAstVisitor<Object> {
* [identifier] is not a name of a getter or a method that exists in the
* class [Null].
*/
- void _checkForCanBeNullAfterNullAware(
- Expression target, Token operator, SimpleIdentifier propertyName, SimpleIdentifier methodName) {
+ void _checkForCanBeNullAfterNullAware(Expression target, Token operator,
+ SimpleIdentifier propertyName, SimpleIdentifier methodName) {
if (operator?.type == TokenType.QUESTION_PERIOD) {
return;
}
@@ -7328,7 +7328,8 @@ class ResolverVisitor extends ScopedVisitor {
!FunctionTypeImpl.relate(
expectedClosureType,
staticClosureType,
- (DartType t, DartType s) => (t as TypeImpl).isMoreSpecificThan(s),
+ (DartType t, DartType s, _, __) =>
+ (t as TypeImpl).isMoreSpecificThan(s),
new TypeSystemImpl().instantiateToBounds,
returnRelation: (s, t) => true)) {
return;
« no previous file with comments | « pkg/analyzer/lib/src/generated/error_verifier.dart ('k') | pkg/analyzer/lib/src/generated/type_system.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698