Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2336493002: Revert of cc: Remove frame queuing from the scheduler. (Closed)

Created:
4 years, 3 months ago by Sam McNally
Modified:
4 years, 3 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Remove frame queuing from the scheduler. (patchset #3 id:40001 of https://codereview.chromium.org/2323063004/ ) Reason for revert: Broke ChromeScreenshotGrabberTest.TakeScreenshot on Linux ChromiumOS Tests (dbg)(1): https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/18015. Original issue's description: > cc: Remove frame queuing from the scheduler. > > CC scheduler has a frame queuing mechanism called "retro frames". This > has been responsible for a lot of complexity and hard to fix bugs. The > original intent for adding retro frames was to allow the scheduler to > handle multiple frames in flight but that goal doesn't seem feasible or > even desirable any more. This CL removes the retro frames queue and > instead makes the Scheduler end the previous frame when it receives a > BeginFrame message. > > One surprising behavior was that SyntheticBFS MISSED frames would be > queued as retro frames and this would convert the synchronous begin > frame call (inside Scheduler::ProcessScheduledActions) to an > asynchronous retro frame PostTask. To work around this the Scheduler > keeps track of a single CancelableClosure that's used for MISSED frames. > > The above behavior was also causing the BeginFramesNotFromClient tests > to work even though there was an extra MISSED frame in the queue. This > is more elegantly solved in another way by using frame number to advance > the task runner instead of just running pending tasks. > > Lastly SchedulerStateMachine is modified so that it's possible to end > the previous frame and still have the same behavior as before in the > commit to active tree (browser compositor) mode. > > R=brianderson@chromium.org,enne@chromium.org,danakj@chromium.org > BUG=602485, 644992 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/559280b26cc5672f5f054e8ac35281e804c14d78 > Cr-Commit-Position: refs/heads/master@{#417764} TBR=enne@chromium.org,brianderson@chromium.org,danakj@chromium.org,sunnyps@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=602485, 644992 Committed: https://crrev.com/95beb47e50065959ee2f5b43cf431431e32e14cd Cr-Commit-Position: refs/heads/master@{#417895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+570 lines, -137 lines) Patch
M cc/scheduler/scheduler.h View 3 chunks +5 lines, -1 line 0 comments Download
M cc/scheduler/scheduler.cc View 11 chunks +101 lines, -32 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 3 chunks +54 lines, -71 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 7 chunks +405 lines, -23 lines 0 comments Download
M cc/test/scheduler_test_common.h View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam McNally
Created Revert of cc: Remove frame queuing from the scheduler.
4 years, 3 months ago (2016-09-12 07:46:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336493002/1
4 years, 3 months ago (2016-09-12 07:47:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 08:36:01 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/95beb47e50065959ee2f5b43cf431431e32e14cd Cr-Commit-Position: refs/heads/master@{#417895}
4 years, 3 months ago (2016-09-12 08:37:43 UTC) #6
sunnyps
4 years, 3 months ago (2016-09-13 22:11:26 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2339633003/ by sunnyps@chromium.org.

The reason for reverting is: Reland after fixing screenshot grabber test and
perf issues..

Powered by Google App Engine
This is Rietveld 408576698