Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3125)

Unified Diff: chrome/browser/ui/cocoa/background_gradient_view.h

Issue 2336463002: Make the edge where BackgroundGradientView draws a divider selectable. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/background_gradient_view.h
diff --git a/chrome/browser/ui/cocoa/background_gradient_view.h b/chrome/browser/ui/cocoa/background_gradient_view.h
index 433fe1f590f7e9ce55516c2e984c8f8b2f084512..ae6f4de816a6b6dcf50255d6c30cfefba8a2d936 100644
--- a/chrome/browser/ui/cocoa/background_gradient_view.h
+++ b/chrome/browser/ui/cocoa/background_gradient_view.h
@@ -9,14 +9,17 @@
#import "chrome/browser/ui/cocoa/themed_window.h"
+enum class BackgroundGradientViewDivider {
Nico 2016/09/12 13:45:55 why enum class? can we come up with something shor
Sidney San Martín 2016/09/14 17:46:59 I'd rather shove one name into the global namespac
+ Bottom,
+ Top,
+};
+
// A custom view that draws a 'standard' background gradient.
// Base class for other Chromium views.
-@interface BackgroundGradientView : NSView<ThemedWindowDrawing> {
- @private
- BOOL showsDivider_;
-}
+@interface BackgroundGradientView : NSView<ThemedWindowDrawing>
-// Controls whether the bar draws a dividing line at the bottom.
+// Controls where and if the bar draws a dividing line.
+@property(nonatomic, assign) BackgroundGradientViewDivider divider;
@property(nonatomic, assign) BOOL showsDivider;
// The color used for the bottom stroke. Public so subclasses can use.

Powered by Google App Engine
This is Rietveld 408576698