BackgroundGradientView: -drawBackground: → -drawRect:

chrome/browser/ui/cocoa/tabs/tab_strip_view.mm

Index: chrome/browser/ui/cocoa/tabs/tab_strip_view.mm
diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm
index 2329650aa54f457d6daf25a517b8faa527c83809..d14f00c8d3b6d8082d166503ccd25f4739e97677 100644
--- a/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm
+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm
@@ -62,11 +62,8 @@
     return;
 
   if (!ui::MaterialDesignController::IsModeMaterial()) {
-    // First draw the toolbar bitmap, so that theme colors can shine through.
     NSRect backgroundRect = [self bounds];
     backgroundRect.size.height = 2 * [self cr_lineWidth];
-    if (NSIntersectsRect(backgroundRect, dirtyRect))
-      [self drawBackground:backgroundRect];

[Nico, 2016/09/12 13:36:11]

this looks unrelated?

[Sidney San Martín, 2016/09/13 19:35:40]

Good catch — I thought these might be dead while I was looking for uses of
drawBackground, but I didn't come back to confirm.

 
     // Draw the border bitmap, which is partially transparent.
     NSImage* image = themeProvider->GetNSImageNamed(IDR_TOOLBAR_SHADE_TOP);
@@ -89,9 +86,6 @@
     // First draw the toolbar bitmap, so that theme colors can shine through.
     NSRect backgroundRect = [self bounds];
     backgroundRect.size.height = [self cr_lineWidth];
-    if (NSIntersectsRect(backgroundRect, dirtyRect)) {
-      [self drawBackground:backgroundRect];
-    }

[Nico, 2016/09/12 13:36:11]

ditto

 
     // Pre-MD the IDR_TOOLBAR_SHADE_TOP image would lay down a light highlight
     // which helped dark toolbars stand out from dark frames. Lay down a thin