BackgroundGradientView: -drawBackground: → -drawRect:

BackgroundGradientView: -drawBackground: → -drawRect:

BackgroundGradientView had a -drawBackground: method that its clients
were expected to call. This change moves background drawing to
-drawRect: so that the it happens by default.

Subclasses that did custom drawing already override -drawRect:, but this
removes a couple of overrides that just forwarded to -drawBackground:.

BUG=589943
Committed: https://crrev.com/6b1939a26d2839136aeeba2aa0e359fce0c20281
Cr-Commit-Position: refs/heads/master@{#418358}

[Sidney San Martín, 2016-09-12 11:53:12]

Description was changed from

==========
BackgroundGradientView: -drawBackground: → -drawRect:

BackgroundGradientView had a -drawBackground: method that its clients
were expected to call. This change moves background drawing to
-drawRect: so that the background gets drawn by default. Subclasses can
still override -drawRect: to customize things (and already were).

BUG=589943
==========

to

==========
BackgroundGradientView: -drawBackground: → -drawRect:

BackgroundGradientView had a -drawBackground: method that its clients
were expected to call. This change moves background drawing to
-drawRect: so that the it happens by default. Subclasses can still
override -drawRect: to customize things (and already do).

BUG=589943
==========

[Sidney San Martín, 2016-09-12 11:53:12]

sdy@chromium.org changed reviewers:
+ thakis@chromium.org

[Sidney San Martín, 2016-09-12 11:56:02]

Description was changed from

==========
BackgroundGradientView: -drawBackground: → -drawRect:

BackgroundGradientView had a -drawBackground: method that its clients
were expected to call. This change moves background drawing to
-drawRect: so that the it happens by default. Subclasses can still
override -drawRect: to customize things (and already do).

BUG=589943
==========

to

==========
BackgroundGradientView had a -drawBackground: method that its clients
were expected to call. This change moves background drawing to
-drawRect: so that the it happens by default.

Subclasses already override -drawRect: to customize things, but this
removes a couple of overrides that just forward to -drawBackground:.

BUG=589943
==========

[Sidney San Martín, 2016-09-12 11:56:15]

Description was changed from

==========
BackgroundGradientView had a -drawBackground: method that its clients
were expected to call. This change moves background drawing to
-drawRect: so that the it happens by default.

Subclasses already override -drawRect: to customize things, but this
removes a couple of overrides that just forward to -drawBackground:.

BUG=589943
==========

to

==========
BackgroundGradientView: -drawBackground: → -drawRect:

BackgroundGradientView had a -drawBackground: method that its clients
were expected to call. This change moves background drawing to
-drawRect: so that the it happens by default.

Subclasses already override -drawRect: to customize things, but this
removes a couple of overrides that just forward to -drawBackground:.

BUG=589943
==========

[Sidney San Martín, 2016-09-12 11:57:37]

Description was changed from

==========
BackgroundGradientView: -drawBackground: → -drawRect:

BackgroundGradientView had a -drawBackground: method that its clients
were expected to call. This change moves background drawing to
-drawRect: so that the it happens by default.

Subclasses already override -drawRect: to customize things, but this
removes a couple of overrides that just forward to -drawBackground:.

BUG=589943
==========

to

==========
BackgroundGradientView: -drawBackground: → -drawRect:

BackgroundGradientView had a -drawBackground: method that its clients
were expected to call. This change moves background drawing to
-drawRect: so that the it happens by default.

Subclasses that did custom drawing already override -drawRect:, but this
removes a couple of overrides that just forwarded to -drawBackground:.

BUG=589943
==========

[Nico, 2016-09-12 13:36:11]

https://codereview.chromium.org/2336453002/diff/1/chrome/browser/ui/cocoa/tab...
File chrome/browser/ui/cocoa/tabs/tab_strip_view.mm (left):

https://codereview.chromium.org/2336453002/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_strip_view.mm:69: [self
drawBackground:backgroundRect];
this looks unrelated?

https://codereview.chromium.org/2336453002/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_strip_view.mm:94: }
ditto

[Sidney San Martín, 2016-09-13 19:21:30]

Patchset #2 (id:20001) has been deleted

[Sidney San Martín, 2016-09-13 19:35:40]

https://codereview.chromium.org/2336453002/diff/1/chrome/browser/ui/cocoa/tab...
File chrome/browser/ui/cocoa/tabs/tab_strip_view.mm (left):

https://codereview.chromium.org/2336453002/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_strip_view.mm:69: [self
drawBackground:backgroundRect];
On 2016/09/12 13:36:11, Nico wrote:
> this looks unrelated?

Good catch — I thought these might be dead while I was looking for uses of
drawBackground, but I didn't come back to confirm.

[Nico, 2016-09-13 19:43:34]

lgtm

[Sidney San Martín, 2016-09-13 19:43:56]

The CQ bit was checked by sdy@chromium.org

[commit-bot: I haz the power, 2016-09-13 19:44:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 20:45:03]

Description was changed from

==========
BackgroundGradientView: -drawBackground: → -drawRect:

BackgroundGradientView had a -drawBackground: method that its clients
were expected to call. This change moves background drawing to
-drawRect: so that the it happens by default.

Subclasses that did custom drawing already override -drawRect:, but this
removes a couple of overrides that just forwarded to -drawBackground:.

BUG=589943
==========

to

==========
BackgroundGradientView: -drawBackground: → -drawRect:

BackgroundGradientView had a -drawBackground: method that its clients
were expected to call. This change moves background drawing to
-drawRect: so that the it happens by default.

Subclasses that did custom drawing already override -drawRect:, but this
removes a couple of overrides that just forwarded to -drawBackground:.

BUG=589943
==========

[commit-bot: I haz the power, 2016-09-13 20:45:06]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-13 20:47:36]

Description was changed from

==========
BackgroundGradientView: -drawBackground: → -drawRect:

BackgroundGradientView had a -drawBackground: method that its clients
were expected to call. This change moves background drawing to
-drawRect: so that the it happens by default.

Subclasses that did custom drawing already override -drawRect:, but this
removes a couple of overrides that just forwarded to -drawBackground:.

BUG=589943
==========

to

==========
BackgroundGradientView: -drawBackground: → -drawRect:

BackgroundGradientView had a -drawBackground: method that its clients
were expected to call. This change moves background drawing to
-drawRect: so that the it happens by default.

Subclasses that did custom drawing already override -drawRect:, but this
removes a couple of overrides that just forwarded to -drawBackground:.

BUG=589943

Committed: https://crrev.com/6b1939a26d2839136aeeba2aa0e359fce0c20281
Cr-Commit-Position: refs/heads/master@{#418358}
==========

[commit-bot: I haz the power, 2016-09-13 20:47:37]

Patchset 2 (id:??) landed as
https://crrev.com/6b1939a26d2839136aeeba2aa0e359fce0c20281
Cr-Commit-Position: refs/heads/master@{#418358}

[Sidney San Martín, 2016-09-14 22:12:54]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2339143003/ by sdy@chromium.org.

The reason for reverting is: AnimatableView inherits from
BackgroundGradientView, so a number of
other views which *don't* want backgrounds end up inheriting from
BackgroundGradientView. This widened the scope of the change beyond what
I intended..