Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2336443004:
add SK_SUPPORT_LEGACY_STREAM_DATA flag for future skia CL (Closed)
Descriptionadd SK_SUPPORT_LEGACY_STREAM_DATA flag for future skia CL
future CL: https://codereview.chromium.org/2333713002/#ps60001
Deprecate
SkData* copyToData()
and replace with
sk_sp<SkData> asData / snapshotAsData / detachAsData ()
BUG=
NOTRY=True
Committed: https://crrev.com/3f032e348e2ce72f160c393d84deb94e4e130ccb
Cr-Commit-Position: refs/heads/master@{#417953}
Patch Set 1 #
Messages
Total messages: 18 (12 generated)
reed@google.com changed reviewers: + fmalita@chromium.org
Description was changed from ========== add SK_SUPPORT_LEGACY_STREAM_DATA flag for future skia CL BUG= ========== to ========== add SK_SUPPORT_LEGACY_STREAM_DATA flag for future skia CL future CL: https://codereview.chromium.org/2333713002/#ps60001 BUG= ==========
Description was changed from ========== add SK_SUPPORT_LEGACY_STREAM_DATA flag for future skia CL future CL: https://codereview.chromium.org/2333713002/#ps60001 BUG= ========== to ========== add SK_SUPPORT_LEGACY_STREAM_DATA flag for future skia CL future CL: https://codereview.chromium.org/2333713002/#ps60001 Deprecate SkData* copyToData() and replace with sk_sp<SkData> asData / snapshotAsData / detachAsData () BUG= ==========
The CQ bit was checked by reed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by fmalita@chromium.org
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== add SK_SUPPORT_LEGACY_STREAM_DATA flag for future skia CL future CL: https://codereview.chromium.org/2333713002/#ps60001 Deprecate SkData* copyToData() and replace with sk_sp<SkData> asData / snapshotAsData / detachAsData () BUG= ========== to ========== add SK_SUPPORT_LEGACY_STREAM_DATA flag for future skia CL future CL: https://codereview.chromium.org/2333713002/#ps60001 Deprecate SkData* copyToData() and replace with sk_sp<SkData> asData / snapshotAsData / detachAsData () BUG= NOTRY=True ==========
The CQ bit was unchecked by reed@google.com
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== add SK_SUPPORT_LEGACY_STREAM_DATA flag for future skia CL future CL: https://codereview.chromium.org/2333713002/#ps60001 Deprecate SkData* copyToData() and replace with sk_sp<SkData> asData / snapshotAsData / detachAsData () BUG= NOTRY=True ========== to ========== add SK_SUPPORT_LEGACY_STREAM_DATA flag for future skia CL future CL: https://codereview.chromium.org/2333713002/#ps60001 Deprecate SkData* copyToData() and replace with sk_sp<SkData> asData / snapshotAsData / detachAsData () BUG= NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== add SK_SUPPORT_LEGACY_STREAM_DATA flag for future skia CL future CL: https://codereview.chromium.org/2333713002/#ps60001 Deprecate SkData* copyToData() and replace with sk_sp<SkData> asData / snapshotAsData / detachAsData () BUG= NOTRY=True ========== to ========== add SK_SUPPORT_LEGACY_STREAM_DATA flag for future skia CL future CL: https://codereview.chromium.org/2333713002/#ps60001 Deprecate SkData* copyToData() and replace with sk_sp<SkData> asData / snapshotAsData / detachAsData () BUG= NOTRY=True Committed: https://crrev.com/3f032e348e2ce72f160c393d84deb94e4e130ccb Cr-Commit-Position: refs/heads/master@{#417953} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3f032e348e2ce72f160c393d84deb94e4e130ccb Cr-Commit-Position: refs/heads/master@{#417953} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
