[Material][Mac] Flag and clean for the Security State Decoration

[Material][Mac] Flag and clean for the Security State Decoration

- Refactored LocationBarViewMac so that animations are not called in
Layout()
- Added flags for the security state decoration

BUG=642977, 646047
Committed: https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357
Cr-Commit-Position: refs/heads/master@{#419289}

[felt, 2016-09-14 05:56:18]

felt@chromium.org changed reviewers:
+ felt@chromium.org

[felt, 2016-09-14 05:56:19]

hey sarah, can you update this to use the flag i'm extending here?
https://codereview.chromium.org/2337103002/ since we already have a flag that's
meant for changing how HTTP is displayed (we simply need a new switch for it)

[felt, 2016-09-14 05:56:59]

On 2016/09/14 05:56:19, felt wrote:
> hey sarah, can you update this to use the flag i'm extending here?
> https://codereview.chromium.org/2337103002/ since we already have a flag
that's
> meant for changing how HTTP is displayed (we simply need a new switch for it)

OH wait, this is different-- nevermind. i should stop reading CLs this late at
night.

[felt, 2016-09-14 05:57:21]

Description was changed from

==========
Flags for the security verbose

BUG=
==========

to

==========
Flags for the security verbose

BUG=
==========

[felt, 2016-09-14 05:57:21]

felt@chromium.org changed reviewers:
- felt@chromium.org

[Kevin Bailey, 2016-09-14 15:02:07]

On 2016/09/14 05:56:59, felt wrote:
> On 2016/09/14 05:56:19, felt wrote:
> > hey sarah, can you update this to use the flag i'm extending here?
> > https://codereview.chromium.org/2337103002/ since we already have a flag
> that's
> > meant for changing how HTTP is displayed (we simply need a new switch for
it)
> 
> OH wait, this is different-- nevermind. i should stop reading CLs this late at
> night.

Hi Sarah,

I see that the bug is for MacOS, but would it make sense to make the flags
common?

[spqchan, 2016-09-14 16:33:39]

Description was changed from

==========
Flags for the security verbose

BUG=
==========

to

==========
Flags for the security verbose + some clean up with the LocationBarViewMac~
[Draft]

BUG=
==========

[spqchan, 2016-09-14 16:48:17]

On 2016/09/14 15:02:07, Kevin Bailey wrote:
> On 2016/09/14 05:56:59, felt wrote:
> > On 2016/09/14 05:56:19, felt wrote:
> > > hey sarah, can you update this to use the flag i'm extending here?
> > > https://codereview.chromium.org/2337103002/ since we already have a flag
> > that's
> > > meant for changing how HTTP is displayed (we simply need a new switch for
> it)
> > 
> > OH wait, this is different-- nevermind. i should stop reading CLs this late
at
> > night.
> 
> Hi Sarah,
> 
> I see that the bug is for MacOS, but would it make sense to make the flags
> common?

Hey Kevin,

I’m just making this MacOS for now (along with the flag)
Once the Views part is implemented, the #ifdef MacOS stuff can be removed.
I’ll make a bug for the Views flag. Would you be able to have time to work on
it?

[spqchan, 2016-09-14 19:29:31]

Description was changed from

==========
Flags for the security verbose + some clean up with the LocationBarViewMac~
[Draft]

BUG=
==========

to

==========
[Material][Mac] Cleaned up and put the security state behind a flag

BUG=642977, 646047
==========

[spqchan, 2016-09-14 19:29:31]

spqchan@chromium.org changed reviewers:
+ rsesek@chromium.org

[spqchan, 2016-09-14 21:27:45]

Description was changed from

==========
[Material][Mac] Cleaned up and put the security state behind a flag

BUG=642977, 646047
==========

to

==========
[Material][Mac] Flag and clean for the Security State Decoration

- Refactored LocationBarViewMac so that animations are not called in
Layout()
- Added flags for the security state decoration

BUG=642977, 646047
==========

[spqchan, 2016-09-14 21:27:56]

PTAL

[Kevin Bailey, 2016-09-15 14:53:54]

On 2016/09/14 21:27:56, spqchan wrote:
> PTAL

Sure, I can take care of the Views side.

[Robert Sesek, 2016-09-15 16:18:13]

https://codereview.chromium.org/2336423002/diff/60001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right):

https://codereview.chromium.org/2336423002/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:507:
is_width_available_for_security_verbose_ = true;
I don't follow why this unconditionally true.

https://codereview.chromium.org/2336423002/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:508: 
nit: extra blank line

[spqchan, 2016-09-15 22:43:32]

PTAL

FYI, I got a clarification that the "Non-secure only" flags should also hide the
EV cert. Because of that, I also made a couple of changes so that the EV cert
will hide if should_show_secure_verbose_ is false. Thanks!

https://codereview.chromium.org/2336423002/diff/60001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right):

https://codereview.chromium.org/2336423002/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:507:
is_width_available_for_security_verbose_ = true;
On 2016/09/15 16:18:13, Robert Sesek wrote:
> I don't follow why this unconditionally true.

only non-EV verbose should be hidden if the width it too narrow.
Added a comment for this.

https://codereview.chromium.org/2336423002/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:508: 
On 2016/09/15 16:18:12, Robert Sesek wrote:
> nit: extra blank line

Done.

[Robert Sesek, 2016-09-16 17:42:30]

LGTM

[spqchan, 2016-09-16 17:45:04]

spqchan@chromium.org changed reviewers:
+ holte@chromium.org

[spqchan, 2016-09-16 17:45:05]

Thanks!

+holte for histograms.xml OWNER

[Steven Holte, 2016-09-16 18:54:55]

lgtm

[spqchan, 2016-09-16 19:41:31]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-09-16 19:41:39]

On 2016/09/16 18:54:55, Steven Holte wrote:
> lgtm

thanks!

[commit-bot: I haz the power, 2016-09-16 19:41:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 21:59:26]

Description was changed from

==========
[Material][Mac] Flag and clean for the Security State Decoration

- Refactored LocationBarViewMac so that animations are not called in
Layout()
- Added flags for the security state decoration

BUG=642977, 646047
==========

to

==========
[Material][Mac] Flag and clean for the Security State Decoration

- Refactored LocationBarViewMac so that animations are not called in
Layout()
- Added flags for the security state decoration

BUG=642977, 646047
==========

[commit-bot: I haz the power, 2016-09-16 21:59:27]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-16 22:01:46]

Description was changed from

==========
[Material][Mac] Flag and clean for the Security State Decoration

- Refactored LocationBarViewMac so that animations are not called in
Layout()
- Added flags for the security state decoration

BUG=642977, 646047
==========

to

==========
[Material][Mac] Flag and clean for the Security State Decoration

- Refactored LocationBarViewMac so that animations are not called in
Layout()
- Added flags for the security state decoration

BUG=642977, 646047

Committed: https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357
Cr-Commit-Position: refs/heads/master@{#419289}
==========

[commit-bot: I haz the power, 2016-09-16 22:01:47]

Patchset 5 (id:??) landed as
https://crrev.com/60196b08a5a39666e08f0416ed53fceeadeef357
Cr-Commit-Position: refs/heads/master@{#419289}