Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 23364005: Change the sourceforge url for site_config defaults (Closed)

Created:
7 years, 4 months ago by Ryan Tseng
Modified:
7 years, 4 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Change the sourceforge url for site_config defaults Update sourceforge SVN checkout URL from that old 1.6.9 SVN server to the new 1.7.7 SVN server URL BUG=275757 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=218851

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M site_config/config_default.py View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 9 (0 generated)
Ryan Tseng
7 years, 4 months ago (2013-08-21 15:01:48 UTC) #1
Ronghua Wu (Left Chromium)
lgtm https://codereview.chromium.org/23364005/diff/1/site_config/config_default.py File site_config/config_default.py (right): https://codereview.chromium.org/23364005/diff/1/site_config/config_default.py#newcode29 site_config/config_default.py:29: sourceforge_url = 'https://svn.code.sf.net/p/%(repo)s/code' DEPS file is still using ...
7 years, 4 months ago (2013-08-21 15:35:20 UTC) #2
Ryan Tseng
https://codereview.chromium.org/23364005/diff/1/site_config/config_default.py File site_config/config_default.py (right): https://codereview.chromium.org/23364005/diff/1/site_config/config_default.py#newcode29 site_config/config_default.py:29: sourceforge_url = 'https://svn.code.sf.net/p/%(repo)s/code' On 2013/08/21 15:35:20, Ronghua Wu wrote: ...
7 years, 4 months ago (2013-08-21 15:38:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/23364005/1
7 years, 4 months ago (2013-08-21 15:38:34 UTC) #4
commit-bot: I haz the power
Presubmit check for 23364005-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 4 months ago (2013-08-21 15:39:21 UTC) #5
Ryan Tseng
[+xusydoc, ilevy] for owners
7 years, 4 months ago (2013-08-21 15:41:10 UTC) #6
cmp_google
lgtm
7 years, 4 months ago (2013-08-21 22:48:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/23364005/1
7 years, 4 months ago (2013-08-21 22:48:49 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-08-21 22:49:45 UTC) #9
Message was sent while issue was closed.
Change committed as 218851

Powered by Google App Engine
This is Rietveld 408576698