Implementation of device metrics emulation in render view.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 2343 matching lines @@
   // Copy over the alternate error page URL so we can have alt error pages in
   // the new render view (we don't need the browser to send the URL back down).
   view->alternate_error_page_url_ = alternate_error_page_url_;
 
   return view->webview();
 }
 
 WebWidget* RenderViewImpl::createPopupMenu(WebKit::WebPopupType popup_type) {
   RenderWidget* widget =
       RenderWidget::Create(routing_id_, popup_type, screen_info_);
+  if (device_emulator_)
+    widget->set_popup_device_emulator(device_emulator_.get());

[aelias_OOO_until_Jul13, 2013/09/20 07:10:14]

This weak pointer is sketchy.  The popup didn't need a connection to the
original RenderWidget for anything before but it needs it for this?  I don't
know popups very well, but there must be a cleaner way to do this.  Perhaps do
something from the Blink side in WebPagePopupImpl?

[dgozman, 2013/09/27 19:02:03]

I don't really want to move this logic to Blink, especially as I don't see any
clear single place for it.
I've changed this to store the numbers instead of pointer to emulator.

   return widget->webwidget();
 }
 
 WebExternalPopupMenu* RenderViewImpl::createExternalPopupMenu(
     const WebPopupMenuInfo& popup_menu_info,
     WebExternalPopupMenuClient* popup_menu_client) {
   // An IPC message is sent to the browser to build and display the actual
   // popup.  The user could have time to click a different select by the time
   // the popup is shown.  In that case external_popup_menu_ is non NULL.
   // By returning NULL in that case, we instruct WebKit to cancel that new
@@ skipping 274 matching lines @@
 }
 
 void RenderViewImpl::showContextMenu(
     WebFrame* frame, const WebContextMenuData& data) {
   ContextMenuParams params = ContextMenuParamsBuilder::Build(data);
   params.source_type = context_menu_source_type_;
   if (context_menu_source_type_ == ui::MENU_SOURCE_TOUCH_EDIT_MENU) {
     params.x = touch_editing_context_menu_location_.x();
     params.y = touch_editing_context_menu_location_.y();
   }
+  OnShowHostContextMenu(&params);
 
   // Plugins, e.g. PDF, don't currently update the render view when their
   // selected text changes, but the context menu params do contain the updated
   // selection. If that's the case, update the render view's state just prior
   // to showing the context menu.
   // TODO(asvitkine): http://crbug.com/152432
   if (ShouldUpdateSelectionTextFromContextMenuParams(selection_text_,
                                                      selection_text_offset_,
                                                      selection_range_,
                                                      params)) {
@@ skipping 3425 matching lines @@
     return;
   if (!webview()->devToolsAgent())
     return;
   webview()->devToolsAgent()->willComposite();
 }
 
 bool RenderViewImpl::AllowPartialSwap() const {
   return allow_partial_swap_;
 }
 
+void RenderViewImpl::SetDeviceEmulationParameters(
+    bool enabled, float device_scale_factor, float root_layer_scale) {
+  if (webview()) {
+    webview()->setDeviceEmulationParameters(
+        enabled, device_scale_factor, root_layer_scale);
+  }
+}
+
 bool RenderViewImpl::ScheduleFileChooser(
     const FileChooserParams& params,
     WebFileChooserCompletion* completion) {
   static const size_t kMaximumPendingFileChooseRequests = 4;
   if (file_chooser_completions_.size() > kMaximumPendingFileChooseRequests) {
     // This sanity check prevents too many file choose requests from getting
     // queued which could DoS the user. Getting these is most likely a
     // programming error (there are many ways to DoS the user so it's not
     // considered a "real" security check), either in JS requesting many file
     // choosers to pop up, or in a plugin.
@@ skipping 407 matching lines @@
   for (size_t i = 0; i < icon_urls.size(); i++) {
     WebURL url = icon_urls[i].iconURL();
     if (!url.isEmpty())
       urls.push_back(FaviconURL(url,
                                 ToFaviconType(icon_urls[i].iconType())));
   }
   SendUpdateFaviconURL(urls);
 }
 
 }  // namespace content