content/browser/aura/gpu_process_transport_factory.cc - Issue 23364002: asan use after free in Aura cc:TextureLayer::Update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/aura/gpu_process_transport_factory.cc

Issue 23364002: asan use after free in Aura cc:TextureLayer::Update (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/aura/gpu_process_transport_factory.cc

diff --git a/content/browser/aura/gpu_process_transport_factory.cc b/content/browser/aura/gpu_process_transport_factory.cc

index 06057138de699d92d887327d23330346e59fec6a..9186374ff2ca64dc10195848a4fa24c0fc59cc4f 100644

--- a/content/browser/aura/gpu_process_transport_factory.cc

+++ b/content/browser/aura/gpu_process_transport_factory.cc

@@ -74,6 +74,7 @@ class OwnedTexture : public ui::Texture, ImageTransportFactoryObserver {

// ImageTransportFactory overrides:

virtual void OnLostResources() OVERRIDE {

DeleteTexture();

cpu_(ooo_6.6-7.5) 2013/08/21 22:50:09 I think we should not call DeleteTexture() here an

piman 2013/08/21 23:01:33 I disagree. It can cause leaks depending on the GL

+ host_context_ = NULL;

}

protected:

« no previous file with comments | « cc/layers/texture_layer.cc ('k') | no next file » | no next file with comments »