Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2336393002:
Add rename-subframe-goback to FlagExpectations for PlzNav (Closed)
DescriptionAdd rename-subframe-goback to FlagExpectations for PlzNav
After https://codereview.chromium.org/2317203002 and
https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigation%20Linux/builds/21220
BUG=607205, 575210
TBR=clamy@chromium.org
Committed: https://crrev.com/c06cd64c0ac3391c8313a89ddaf510e3cdee232b
Cr-Commit-Position: refs/heads/master@{#418842}
Patch Set 1 #
Messages
Total messages: 18 (12 generated)
Description was changed from ========== Add rename-subframe-goback to FlagExpectations for PlzNav After https://codereview.chromium.org/2317203002 and https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigatio... BUG=607205,575210 R=clamy@chromium.org ========== to ========== Add rename-subframe-goback to FlagExpectations for PlzNav After https://codereview.chromium.org/2317203002 and https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigatio... BUG=607205,575210 TBR=clamy@chromium.org ==========
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
(please cq if looks ok to you)
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by clamy@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add rename-subframe-goback to FlagExpectations for PlzNav After https://codereview.chromium.org/2317203002 and https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigatio... BUG=607205,575210 TBR=clamy@chromium.org ========== to ========== Add rename-subframe-goback to FlagExpectations for PlzNav After https://codereview.chromium.org/2317203002 and https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigatio... BUG=607205,575210 TBR=clamy@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add rename-subframe-goback to FlagExpectations for PlzNav After https://codereview.chromium.org/2317203002 and https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigatio... BUG=607205,575210 TBR=clamy@chromium.org ========== to ========== Add rename-subframe-goback to FlagExpectations for PlzNav After https://codereview.chromium.org/2317203002 and https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigatio... BUG=607205,575210 TBR=clamy@chromium.org Committed: https://crrev.com/c06cd64c0ac3391c8313a89ddaf510e3cdee232b Cr-Commit-Position: refs/heads/master@{#418842} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c06cd64c0ac3391c8313a89ddaf510e3cdee232b Cr-Commit-Position: refs/heads/master@{#418842} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
